Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Checkbox refactor #1185

Merged
merged 6 commits into from
Apr 22, 2015
Merged

Checkbox refactor #1185

merged 6 commits into from
Apr 22, 2015

Conversation

mbeard
Copy link
Contributor

@mbeard mbeard commented Mar 23, 2015

Refactoring of checkbox

@mbeard
Copy link
Contributor Author

mbeard commented Mar 24, 2015

I disagree. We shouldn't support setting the checked appearance without setting the checked state. Why would we ever want those to be out of sync. Same for disabled.

@swilliamset
Copy link
Contributor

My statement was assuming the function setting the class would insure the control state was synced but i see how the existing function name could cause that confusion.

mbeard added 2 commits March 24, 2015 18:28
…ged destroy so that is only destroys the element that was initialized
@interactivellama interactivellama added this to the 3.7.0 milestone Apr 3, 2015
@swilliamset swilliamset changed the title Checkbox Checkbox refactor Apr 3, 2015
@swilliamset
Copy link
Contributor

@sjames include undocumented methods no longer available in the release notes

@interactivellama
Copy link
Contributor

The following undocumented public methods have been removed from checkbox:
setState, _toggleCheckedState, _toggleDisabledState, _setDisabledClass, and _setCheckedClass

Additionally, the radio and checkbox controls are now bound to the parent element with the respective .radio and .checkbox classes and no longer to the <input> element.

@mbeard Anything else that you would like to see in the release notes?

@chriscorwin
Copy link
Contributor

Highlight isn't working.

The rule to add the background needs changed.

Right here:

https://github.com/mbeard/fuelux/blob/master/less/checkbox.less#L16

...change it to this:

&.checked label.checkbox-custom, label.checked.checkbox-custom {

@chriscorwin chriscorwin assigned mbeard and unassigned chriscorwin Apr 13, 2015
@swilliamset swilliamset modified the milestones: 3.7.1, 3.7.0 Apr 14, 2015
@interactivellama interactivellama modified the milestones: 3.7.1, 3.7.2 Apr 22, 2015
chriscorwin added a commit that referenced this pull request Apr 22, 2015
@chriscorwin chriscorwin merged commit f475eab into ExactTarget:master Apr 22, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants