Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Make datepicker type colors and border radius consistent #1184

Merged
merged 5 commits into from
Mar 23, 2015
Merged

Make datepicker type colors and border radius consistent #1184

merged 5 commits into from
Mar 23, 2015

Conversation

chriscorwin
Copy link
Contributor

Fixes #1088

@chriscorwin
Copy link
Contributor Author

I should mention that I did some JS work in this to add .first and .last classnames on the .next-month and .last-month table cell elements, in order to have them appear as one "bar" with rounded corners on each end.

screenshot 2015-03-23 10 25 39

@kevinparkerson kevinparkerson self-assigned this Mar 23, 2015
kevinparkerson
kevinparkerson reviewed Mar 23, 2015
View reviewed changes
less/datepicker.less
border: 1px solid #333;
b, button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why has this border styling been transferred to the span vs the b, button? It appears to look ok like that, just was curious about the reasoning. Might as well remove this b, button definition then since it is empty.

@chriscorwin
Copy link
Contributor Author

The button is subtly different size than the span, so when the outline for selected is on it, the background colour of the span sticks out further than the button's border.

Here's how it was:

screenshot 2015-03-23 12 36 18

...and here is how it is with my fix:

screenshot 2015-03-23 12 37 34

@kevinparkerson
Copy link
Contributor

Ah yes... there's a reason the button is smaller (strikethrough or some other purpose, forgot) but I agree having around the full span makes more sense for the "current day" outline.

kevinparkerson pushed a commit that referenced this pull request Mar 23, 2015
Merge pull request #1184 from chriscorwin/GH1088---datepicker-type-co…
a40fc16 
…lors-and-border-radius-inconsistent-with-rest-of-fuel-ux

Datepicker type colors and border radius inconsistent with rest of fuel ux
@kevinparkerson kevinparkerson merged commit a40fc16 into ExactTarget:master Mar 23, 2015
@kevinparkerson kevinparkerson added this to the 3.6.5 milestone Mar 23, 2015
@chriscorwin chriscorwin deleted the GH1088---datepicker-type-colors-and-border-radius-inconsistent-with-rest-of-fuel-ux branch April 2, 2015 16:52
@interactivellama interactivellama changed the title Datepicker type colors and border radius inconsistent with rest of fuel ux Make datepicker type colors and border radius consistent with rest of library Apr 7, 2015
@interactivellama interactivellama changed the title Make datepicker type colors and border radius consistent with rest of library Make datepicker type colors and border radius consistent Apr 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@kevinparkerson kevinparkerson

Labels
Confirmed bug datepicker
Projects
None yet
Milestone
3.6.5
Development

Successfully merging this pull request may close these issues.

Datepicker: type colors and border radius inconsistent with rest of Fuel UX
2 participants
@chriscorwin @kevinparkerson