Adds multiple tree open (disclose) and close API methods #1125

cmcculloh-kr · 2015-02-24T14:42:27Z

fixes #1105 fixes #1106

…er things to disclose

…l for parity with disclose and clarity on purpose. Adds example to index.

…t testing

… page

…ones. Adds new trigger to occur each round executes that exceeds the set upper limit. Allows the upper limit to be infinite. Makes triggers pass along more useful data. Reformats and clarifies comments

tweettypography · 2015-02-24T21:50:05Z

js/tree.js

+				}
+			};
+
+			//trigger callback when all folders have reported opened


Comment should say "closed" not "opened"

…and redundant setting of in test

…ree-disclosures

…op by default. If dev wants loop to continue, they can set ignore-disclosures-limit to false and start loop again. Updated unit tests

Gh1105 tree disclosures

cmcculloh added 10 commits February 20, 2015 14:50

(tree-disclose-all) adds disclosure methods

0688b4c

make discloseAll wait for loaded event before re-inspecting for furth…

0abeedd

…er things to disclose

adds an upperlimit kill switch. Adds example usages to index page

132d5ea

fixes #1106 makes collapse actually work. Aliases collapse as closeAl…

52301ae

…l for parity with disclose and clarity on purpose. Adds example to index.

esformatter run on tree-test.js

d15f451

added better triggers and event ordering based on findings during uni…

610de1f

…t testing

added unit tests

e81fba0

adds more example listeners for the new folder triggers to test index…

0a83177

… page

fixes bug with collapse firing on _all_ folders instead of just open …

49d3156

…ones. Adds new trigger to occur each round executes that exceeds the set upper limit. Allows the upper limit to be infinite. Makes triggers pass along more useful data. Reformats and clarifies comments

fix jshint errors

49bf7b2

futuremint added the tree label Feb 24, 2015

futuremint added this to the 3.6.3 milestone Feb 24, 2015

futuremint added the Enhancement label Feb 24, 2015

swilliamset assigned swilliamset and tweettypography and unassigned swilliamset Feb 24, 2015

make mocked-up data source for tree connected to test buttons be finite

03a187a

tweettypography reviewed Feb 24, 2015
View reviewed changes

js/tree.js

}

};

//trigger callback when all folders have reported opened

Copy link

Contributor

tweettypography Feb 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should say "closed" not "opened"

cmcculloh added 4 commits February 24, 2015 19:20

simplifies discloseAll a bit. Corrects comments. Removes console.log …

8fb4d93

…and redundant setting of in test

reverse accidental diff commit

ca189dd

Merge branch 'master' of github-ET:ExactTarget/fuelux into GH1105---t…

c9ed7d0

…ree-disclosures

makes disclosuresUpperLimit default to 0, and if reached, kill the lo…

b9098d4

…op by default. If dev wants loop to continue, they can set ignore-disclosures-limit to false and start loop again. Updated unit tests

tweettypography added a commit that referenced this pull request Feb 25, 2015

Merge pull request #1125 from cormacmccarthy/GH1105---tree-disclosures

707a476

Gh1105 tree disclosures

tweettypography merged commit 707a476 into ExactTarget:master Feb 25, 2015

interactivellama changed the title ~~Gh1105 tree disclosures~~ Adds multiple tree open (disclose) and close API methods Feb 26, 2015

cmcculloh-kr deleted the GH1105---tree-disclosures branch March 24, 2015 14:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds multiple tree open (disclose) and close API methods #1125

Adds multiple tree open (disclose) and close API methods #1125

cmcculloh-kr commented Feb 24, 2015

tweettypography Feb 24, 2015

Adds multiple tree open (disclose) and close API methods #1125

Adds multiple tree open (disclose) and close API methods #1125

Conversation

cmcculloh-kr commented Feb 24, 2015

tweettypography Feb 24, 2015

Choose a reason for hiding this comment