This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Add code coverage to QUnit tests #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e552c95 to
ad298cd
Compare
| @@ -546,12 +574,14 @@ module.exports = function (grunt) { | |||
|
|
|||
| if (!grunt.option('no-tests')) { | |||
| grunt.task.run(['releasetest']); | |||
| //delete any screenshots that may have happened if it got this far. This isn't foolproof because it relies on the phantomjs server/page timeout, which can take longer than this grunt task depending on how long saucelabs takes to run... | |||
| // Delete any screenshots that may have happened if it got this far. This isn't foolproof | |||
There was a problem hiding this comment.
what's up with splitting this onto multiple lines?
There was a problem hiding this comment.
I couldn't read it. It went off the page. I don't have line wrap on, do you? I thought we typically tried to keep code to 80 characters, so it doesn't wrap. I looked into the styleguide and didn't see any mention of line length. Maybe we we should add a recommendation?
The 80 standard length due to IBM punch cards, but in magazines articles, for instance, I don't think columns are supposed to be over 9 words for readability. You also have to scroll within this GH interface and on your phone farther.
http://stackoverflow.com/questions/903754/do-you-still-limit-line-length-in-code
dda0ef4 to
27c91b6
Compare
- QUnit runs global variables test and test on dist (when needed) - Blanket QUnit runs source file tests with code coverage. Threshold has been set to 1%, so that it can be ignored and that tests would still pass. - Remove references to `lib` folder in watch task - Add all tests to `serve` task and make it "do everything." - Add a `serveslow` task to do all tests on source without building dist - Rename qunit:simple to qunit:source for accuracy - Add length of time to aid developers in choosing a serve task - Remove 'feulux-' filename prefix from tests, and add tests.html as a default file when serving. - Re-order tests, so that `blanket_qunit` will fail first. Globals hardly ever fails for obvious reasons.
27c91b6 to
1593961
Compare
cmcculloh-kr
pushed a commit
that referenced
this pull request
Feb 25, 2015
…and-serve Refactor QUnit with code coverage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1081 in that it will fail if the coverage decreases. Current threshold is 68 in individual controls and 81 as an average overall. If you add functionality, you will need to add unit tests now for tests to pass.
Issues:
dist.Needed changes:
libfolder in watch taskservetask and make it "do everything."serveslowtask to do all tests on source without building distblanket_qunitwill fail first. Globals hardly ever fails for obvious reasons.