Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Gh1019 deprecate checkbox and radio buttons #1115

Merged
merged 1 commit into from
Mar 4, 2015
Merged

Gh1019 deprecate checkbox and radio buttons #1115

merged 1 commit into from
Mar 4, 2015

Conversation

chriscorwin
Copy link
Contributor

Modified styles for radio and checkbox so that they will look correct when the custom controls are deprecated.

Added a new "dev" workflow to grunt, along with a servedev task that bypasses building the normal dist/ stuff, added things to .gitignore for the files it does make.

@cmcculloh-kr cmcculloh-kr added this to the 3.6.3 milestone Feb 20, 2015
@cmcculloh-kr cmcculloh-kr self-assigned this Feb 20, 2015
@cmcculloh-kr
Copy link

Hey, nice, it isn't a breaking change!

We'll wait until the 3.7.0 release to rip out ye ole checkbox/radio then...

@cmcculloh-kr
Copy link

closes #1113, #1059, #1050, fixes #1019 and #1107

@cmcculloh-kr
Copy link

please rebase to master and address any merge issues. Thanks!

@chriscorwin
Copy link
Contributor Author

Assigning back to @CormacMcCarthy now that I've tested the merge out and it seems okay.

@interactivellama
Copy link
Contributor

Please add text to the original PR comment above stating this does not work in all browsers, specifically all versions of IE (8-11) (although, I hear Windows Phone might). We should note that -moz-appearance and -webkit-appearance are non-standard CSS features and may disappear at a point in the future. From MDN:

Non-standard
This feature is non-standard and is not on a standards track. Do not use it on production sites facing the Web: it will not work for every user. There may also be large incompatibilities between implementations and the behavior may change in the future.

@interactivellama
Copy link
Contributor

Please fix:

  • Firefox compatibility
  • HTML validation issues
  • dev workflow changes may need to go in a different PR since it's not related to checkbox/radio.

@interactivellama
Copy link
Contributor

Closing until we figure out a fix.

@interactivellama interactivellama modified the milestones: 3.6.4, 3.6.3 Feb 26, 2015
@swilliamset
Copy link
Contributor

Lets keep these open if they are still in progress (even if "in a completely different way"). Owner should force push to fork when complete.

@swilliamset swilliamset reopened this Feb 27, 2015
@chriscorwin
Copy link
Contributor Author

Wait again on this --- bug in radio with alignment.

@interactivellama
Copy link
Contributor

I'll take it when it's ready again.

@chriscorwin
Copy link
Contributor Author

It's ready, sorry.

@interactivellama
Copy link
Contributor

Please fix:

  • HTML validation issues

@chriscorwin
Copy link
Contributor Author

Validation warnings laxed to account for header in section thing, and ARIA controls issues fixed.

Also have merged in lastest master and resolved conflicts with @cmcculloh work involving auto-linking to sections in the index.html file.

Ready to test one more time!

@chriscorwin chriscorwin force-pushed the GH1019---deprecate-checkbox-and-radio-buttons branch from b326355 to 46958de Compare March 4, 2015 22:32
Checkbox and radio button style and markup work done in advance of de…
1965055 
…precating the custom controls javascript. New grunt servedev task added to Gruntfile.js for LESS dev work. New markup examples added.

Checkbox and radio button style and markup work done in advance of deprecating the custom controls javascript. New grunt servedev task added to Gruntfile.js for LESS dev work. New markup examples added.
@chriscorwin chriscorwin force-pushed the GH1019---deprecate-checkbox-and-radio-buttons branch from 5ee55b7 to 1965055 Compare March 4, 2015 22:35
interactivellama added a commit that referenced this pull request Mar 4, 2015
@interactivellama
Merge pull request #1115 from chriscorwin/GH1019---deprecate-checkbox…
c46db95 
…-and-radio-buttons

Gh1019   deprecate checkbox and radio buttons
@interactivellama interactivellama merged commit c46db95 into ExactTarget:master Mar 4, 2015
@chriscorwin chriscorwin deleted the GH1019---deprecate-checkbox-and-radio-buttons branch April 2, 2015 16:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@chriscorwin chriscorwin

Labels
checkbox/radio Documentation Enhancement
Projects
None yet
Milestone
3.6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@chriscorwin @cmcculloh-kr @interactivellama @swilliamset