Bugfix for repeater list extension returning wrong rowData object in rowRenderer callback. #1077
Conversation
of the rowData object now.
| @@ -379,7 +379,7 @@ | |||
| this.viewOptions.list_rowRendered({ | |||
| container: $tbody, | |||
| item: $row, | |||
| rowData: data | |||
| rowData: data.items[index] | |||
There was a problem hiding this comment.
this can be simplified to just subset[index] I was already passing in the correct "items" array as the subset arg, I just mistakingly put the wrong argument there >.<
There was a problem hiding this comment.
what even is subset? That variable name needs to change...
There was a problem hiding this comment.
These docs will change soon, but: http://getfuelux.com/extensions.html#writing-extensions-repeater-helpers
It's the "subset" of information that is being iterated over. In this case, data.items. renderRow is called passing the helpers.subset value as the subset argument. I suppose it could be renamed "items" in the scope of the renderRow function...
There was a problem hiding this comment.
Is there any case where it isn't just a convenience accessor for the data.items param?
|
Nice catch!!! |
Bugfix for repeater list extension returning wrong rowData object in rowRenderer callback.
Adds unit tests to both list callbacks to verify the shape of the rowData object now.
Fixes #1075.