ensured the scheduler input checked attribute is being set, not just setting the active css class

[mbeard]

fixes #992

[swilliamset]

@mbeard travis is failing on test failing

[cmcculloh-kr]

It doesn't look like your unit test is checking for the checked attr to be present and true, is this on purpose?

[mbeard]

I was intending to test getValue which in turn tests this indirectly. I will create a separate unit test to explicitly test the checked attribute.

[cmcculloh-kr]

I believe this should be .prop('checked', true) not attr('checked', true). http://api.jquery.com/prop/

the most important concept to remember about the checked attribute is that it does not correspond to the checked property. The attribute actually corresponds to the defaultChecked property and should be used only to set the initial value of the checkbox. The checked attribute value does not change with the state of the checkbox, while the checked property does.

[cmcculloh-kr]

OK, I can confirm that .attr('checked') is not getting set "under the covers":

But if we set it, it will be set:

and furthermore, if we use attr() instead of prop(), despite what the jquery docs tell us, it appears to work better:

[mbeard]

Why not rely on our defined API for interrogating the scheduler vs. supporting inspecting the classnames, attributes, etc. on the DOM elements of the scheduler?

The latter seems to be problematic and cause for future issues.

[cmcculloh-kr]

This has possible ramifications for anyone who was incorrectly accessing the value using attr instead of interrogating our API using getValue or change event (or, worst case, using prop)

[interactivellama]

We have something in that essentially said we will legacy support our API and initial markup if we change it, custom DOM interrogating though may break, but I can't find it now.

Here it is. It's only about events though.

Listening for standard and Bootstrap supported events on an internal element is not tested, and therefore not recommended.

We could add a disclaimer for markup and/or jQuery selectors inspecting into the control, etc.

[swilliamset]

Should we add access attributes directly from markup to this? This isn't the first time we've ran into attributes not being synced. It's a common problem with jQuery objects.