-
Notifications
You must be signed in to change notification settings - Fork 1k
Solution needed for selectlist [data-resize]=auto when display: none
- fixes #1069
#1073
Solution needed for selectlist [data-resize]=auto when display: none
- fixes #1069
#1073
Conversation
@@ -53,6 +53,9 @@ input, textarea { | |||
visibility: hidden; | |||
top: 0; | |||
float: left; | |||
.selectlist { | |||
display: block !important; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
uncomfortable with an !important
here. is there a place we can do the following
- check if visible
- if hidden
- change visibility transparent
- show
- measure
- reset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is just for the dummy selectlist I create. The element I append to the body to get the width of the dropdown items then remove once I have a width.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets provide a more explicit class name then to make it clear it's a dummy
.dummy-selectlist
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If "sizer" is good enough for the js variable name, why are we deviating from that in the CSS? Now it is inconsistent and even more confusing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sizer is fine. We can move back. I wasn't looking at the context of the css class.
725050f
to
d7378bf
Compare
Are we able to test this in a unit test? |
@CormacMcCarthy Were you testing it in the selectlist test markup? |
@BenjaminNeilDavis I clicked on the link you provided: (http://jsbin.com/beyogiqizi/) and it was borked. |
c2b6c86
to
bf9cf2d
Compare
@CormacMcCarthy I was just mainly providing the html for the tests (because dev file is now ignored). The js / css for fuelux is pointing to the CDN which doesnt have my changes yet. If you were to copy the html / js from the example and use it on the dev.html page you would be able to see the change. |
bb2bc0c
to
92e5ffc
Compare
…splay block so its width sets correctly, don't let its width be set to 1 or less.
I think a bad squash resulted in losing some code. |
3ca0d9c
to
5451fad
Compare
… test final element against inner text as it appears on page
…om/cormacmccarthy/fuelux into issue-1069-selectlist-display-none
799c47d
to
59813bd
Compare
…-display-none
Solution needed for selectlist [data-resize]=auto when `display: none`- fixes #1069
display: none