Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Solution needed for selectlist [data-resize]=auto when display: none- fixes #1069 #1073

Conversation

BenjaminNeilDavis
Copy link
Contributor

  • fixes #1069
  • Solution needed for selectlist [data-resize]=auto when display: none
  • added catch if width returns as 0 and displays selectlist as normal.
  • different test examples http://jsbin.com/beyogiqizi/

@@ -53,6 +53,9 @@ input, textarea {
visibility: hidden;
top: 0;
float: left;
.selectlist {
display: block !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uncomfortable with an !important here. is there a place we can do the following

  • check if visible
  • if hidden
    • change visibility transparent
    • show
    • measure
    • reset

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for the dummy selectlist I create. The element I append to the body to get the width of the dropdown items then remove once I have a width.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets provide a more explicit class name then to make it clear it's a dummy
.dummy-selectlist

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If "sizer" is good enough for the js variable name, why are we deviating from that in the CSS? Now it is inconsistent and even more confusing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sizer is fine. We can move back. I wasn't looking at the context of the css class.

@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1069-selectlist-display-none branch from 725050f to d7378bf Compare February 10, 2015 21:43
@BenjaminNeilDavis BenjaminNeilDavis added this to the 3.6.0 milestone Feb 11, 2015
@cmcculloh-kr cmcculloh-kr self-assigned this Feb 11, 2015
@cmcculloh-kr
Copy link

Are we able to test this in a unit test?

@cmcculloh-kr
Copy link

Your "hidden on load" test example is breaking:

image

@BenjaminNeilDavis
Copy link
Contributor Author

@CormacMcCarthy Were you testing it in the selectlist test markup?

@cmcculloh-kr
Copy link

@BenjaminNeilDavis I clicked on the link you provided:

image

(http://jsbin.com/beyogiqizi/)

and it was borked.

@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1069-selectlist-display-none branch from c2b6c86 to bf9cf2d Compare February 11, 2015 18:05
@BenjaminNeilDavis
Copy link
Contributor Author

@CormacMcCarthy I was just mainly providing the html for the tests (because dev file is now ignored). The js / css for fuelux is pointing to the CDN which doesnt have my changes yet. If you were to copy the html / js from the example and use it on the dev.html page you would be able to see the change.

@cmcculloh-kr
Copy link

Indeed! Thanks :)

image

@cmcculloh-kr cmcculloh-kr removed their assignment Feb 11, 2015
@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1069-selectlist-display-none branch 7 times, most recently from bb2bc0c to 92e5ffc Compare February 11, 2015 21:30
@cmcculloh-kr
Copy link

I think a bad squash resulted in losing some code.

@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1069-selectlist-display-none branch 2 times, most recently from 3ca0d9c to 5451fad Compare February 12, 2015 18:03
@BenjaminNeilDavis BenjaminNeilDavis force-pushed the issue-1069-selectlist-display-none branch from 799c47d to 59813bd Compare February 12, 2015 19:06
futuremint added a commit that referenced this pull request Feb 12, 2015
…-display-none

Solution needed for selectlist [data-resize]=auto when `display: none`- fixes #1069
@futuremint futuremint merged commit dc1cc67 into ExactTarget:master Feb 12, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solution needed for selectlist [data-resize]=auto when display: none
5 participants