This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Added data-name for selectedItem #1031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Ability to change step based on data-name of the wizard pane instead of just step id.
Ability to Match selectedItem steps by Data-name
|
Please add some unit tests to test this additional functionality. See step 1 from our contribution steps. Thanks. |
|
@swbullis please add unit tests to this so that we can consider merging this or not. Thanks. |
|
fixes #607 @swbullis thank you for your contribution and interest. Let me know if you need some help figuring out the unit test stuff. |
|
closing while waiting for unit test |
|
I need to be able to clone it to add the unit tests, which I don't know how to do while it is closed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Ability to change step based on data-name of the wizard pane instead of just step id.