Merge pull request #1961 from swilliamset/repair-travis-qunit

Repair travis qunit
ExactTarget · Apr 19, 2017 · d7c3ac8 · d7c3ac8
2 parents 8f24eab + 5c61b38
commit d7c3ac8
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/bower.json b/bower.json
@@ -25,7 +25,7 @@
   "devDependencies": {
     "jquery": null,
     "jquery-1.9.1": "jquery#1.9.1",
-    "qunit": "2.x",
+    "qunit": "2.3.0",
     "requirejs-text": "2.x",
     "underscore": "1.x",
     "blanket": "1.x",

diff --git a/test/repeater-test.js b/test/repeater-test.js
@@ -380,14 +380,12 @@ define( function ( require ) {
 	QUnit.test( 'rendered.fu.repeater callback should receive correct data when called by renderItems function', function dataSourceCallbackTest( assert ) {
 		var ready = assert.async();
 		var $repeater = $( this.$markup );
-		var count = 0;
 		$repeater.on( 'rendered.fu.repeater', function rendered ( e, state ) {
-			count++;
+			// rendered is triggered on `this.$search` and `this.$element` in repeater.js
+			if ( e.target.id === $repeater.attr('id') ) {
+				assert.ok( state.data, 'data object exists' );
+				assert.equal( state.data.myVar, 'passalong', 'data returned from datasource was passed along' );
 
-			assert.ok( state.data, 'data object exists' );
-			assert.equal( state.data.myVar, 'passalong', 'data returned from datasource was passed along' );
-
-			if ( count === 2 ) {
 				ready();
 			}
 		} );