Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Commit

Permalink
Merge pull request #629 from ExactTarget/checkradio-highlight-padding
Browse files Browse the repository at this point in the history
checkradio-highlight-padding: fixing checkbox and radio highlight left p...
  • Loading branch information
interactivellama committed Aug 28, 2014
2 parents b65093f + d6775ee commit 38f345d
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 21 deletions.
6 changes: 3 additions & 3 deletions dist/css/fuelux.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/css/fuelux.css.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/css/fuelux.min.css

Large diffs are not rendered by default.

Binary file modified dist/fuelux.zip
Binary file not shown.
18 changes: 9 additions & 9 deletions dist/js/fuelux.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*!
* FuelUX v3.0.0
* Fuel UX v3.0.0
* Copyright 2012-2014 ExactTarget
* Licensed under the BSD New license (https://github.com/ExactTarget/fuelux/blob/master/LICENSE)
*/
Expand All @@ -15,11 +15,11 @@
}( function( jQuery ) {

if ( typeof jQuery === 'undefined' ) {
throw new Error( 'FuelUX\'s JavaScript requires jQuery' )
throw new Error( 'Fuel UX\'s JavaScript requires jQuery' )
}

if ( typeof $.fn.dropdown === 'undefined' || typeof $.fn.collapse === 'undefined' ) {
throw new Error( 'FuelUX\'s JavaScript requires Bootstrap' )
if ( typeof jQuery.fn.dropdown === 'undefined' || typeof jQuery.fn.collapse === 'undefined' ) {
throw new Error( 'Fuel UX\'s JavaScript requires Bootstrap' )
}

( function( $ ) {
Expand Down Expand Up @@ -832,15 +832,15 @@
if ( topPercentage < 5 ) {
start = parseInt( $yearUl.find( 'li:first' ).attr( 'data-year' ), 10 );
for ( i = ( start - 1 ); i > ( start - 11 ); i-- ) {
$yearUl.prepend( '<li data-year="' + i + '"><button>' + i + '</button></li>' );
$yearUl.prepend( '<li data-year="' + i + '"><button type="button">' + i + '</button></li>' );
}
this.artificialScrolling = true;
$yearUl.scrollTop( ( $yearUl.get( 0 ).scrollHeight - scrollHeight ) + scrollTop );
this.artificialScrolling = false;
} else if ( bottomPercentage > 90 ) {
start = parseInt( $yearUl.find( 'li:last' ).attr( 'data-year' ), 10 );
for ( i = ( start + 1 ); i < ( start + 11 ); i++ ) {
$yearUl.append( '<li data-year="' + i + '"><button>' + i + '</button></li>' );
$yearUl.append( '<li data-year="' + i + '"><button type="button">' + i + '</button></li>' );
}
}
},
Expand Down Expand Up @@ -953,7 +953,7 @@
for ( i = 0; i < rows; i++ ) {
$tr = $( '<tr></tr>' );
for ( j = 0; j < 7; j++ ) {
$td = $( '<td><span><button class="datepicker-date">' + curDate + '</button></span></td>' );
$td = $( '<td><span><button type="button" class="datepicker-date">' + curDate + '</button></span></td>' );
if ( stage === -1 ) {
$td.addClass( 'last-month' );
} else if ( stage === 1 ) {
Expand Down Expand Up @@ -1028,7 +1028,7 @@

$yearUl.empty();
for ( i = ( year - 10 ); i < ( year + 11 ); i++ ) {
$yearUl.append( '<li data-year="' + i + '"><button>' + i + '</button></li>' );
$yearUl.append( '<li data-year="' + i + '"><button type="button">' + i + '</button></li>' );
}
$yearSelected = $yearUl.find( 'li[data-year="' + year + '"]' );
$yearSelected.addClass( 'selected' );
Expand Down Expand Up @@ -2159,7 +2159,7 @@
this.$selectedItem = $selectedItem = $item;

this.$hiddenField.val( this.$selectedItem.attr( 'data-value' ) );
this.$label.text( this.$selectedItem.text() );
this.$label.html( $( this.$selectedItem.children()[ 0 ] ).html() );

// clear and set selected item to allow declarative init state
// unlike other controls, selectlist's value is stored internal, not in an input
Expand Down
8 changes: 4 additions & 4 deletions dist/js/fuelux.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion less/checkbox.less
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.checkbox {

&.highlight {
padding: 4px 4px 4px 24px;
padding: 4px;

&.checked {
background: #e9e9e9;
Expand Down
2 changes: 1 addition & 1 deletion less/radio.less
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
.radio {
&.highlight {
padding: 4px 4px 4px 24px;
padding: 4px;

&.checked {
background: #e9e9e9;
Expand Down

0 comments on commit 38f345d

Please sign in to comment.