Partially solving Issue #150: time of flight #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation In order to unify the spelling, I suggest to be consistent in writing 'TOF'/'time-of-flight'/'time of flight'. Only the term 'time-of-flight spectrometry' (PaNET1244) uses dashes. Only the term 'pulsed neutron TOF probe' (PaNET01019) solely uses 'TOF' without having an Alt Label with the fully written term. Modification The Label of PaNET1244 is now 'time of flight spectrometry'. The Label of PaNET01019 is now 'pulsed neutron time of flight probe' with the Alt Label 'pulsed neutron TOF probe'. No further changes are induced. Result The notation of 'time of flight' is consistent within the ontology. The test with panet-build was successful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In order to unify the spelling, I suggest to be consistent in writing 'TOF'/'time-of-flight'/'time of flight'. Only the term 'time-of-flight spectrometry' (PaNET1244) uses dashes. Only the term 'pulsed neutron TOF probe' (PaNET01019) solely uses 'TOF' without having an Alt Label with the fully written term.
Modification
The Label of PaNET1244 is now 'time of flight spectrometry'. The Label of PaNET01019 is now 'pulsed neutron time of flight probe' with the Alt Label 'pulsed neutron TOF probe'. No further changes are induced.
Result
The notation of 'time of flight' is consistent within the ontology. The test with panet-build was successful.