This repository has been archived by the owner on May 13, 2022. It is now read-only.
forked from facebook/create-react-app
-
Notifications
You must be signed in to change notification settings - Fork 3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
…#9921) Co-authored-by: Konstantin Simeonov <kon.simeonov@protonmail.com>
…k#10052) Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
- remove `react-dev-utils/inquirer` public import
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>
This reverts commit 580ed5d.
…t-refresh-webpack-plugin (facebook#9872)
Some library --> Some libraries
Co-authored-by: mad-jose <joset@yeswearemad.com>
Resolves facebook#10084 security vulnerability in websocket-driver library version 0.5.6, imported transitively by sockjs
Resolves facebook#10411 Bumps immer version to 8.0.1 to address the prototype pollution vulnerability with the current 7.0.9 version.
theinterned
approved these changes
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good!
I didn't see where the eslint was reenabled though. Never mind I found it. Looks good.
Yeah it was done as part of the merge commit, which in retrospect was a bad idea! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the changes from Create React App 4.0.3.
Notable changes
DISABLE_ESLINT_PLUGIN
environment variable. That makes one of our customizations (disabling the ESLint plugin from https://github.com/EverlongProject/create-react-app/pull/29/files#r527210700) unnecessary.DISABLE_ESLINT_PLUGIN
when updating them to this version.BUILD_PATH
environment variable that can be used to customize the build output location. This could be helpful for simplifying theleague-web
CI config (by removing the need to manually rename the build output folder). I will followup on that separately inleague-web
.