[FRONTEND-191] Update to v4.0.0 #29

panbenson · 2020-11-18T16:45:43Z

Update our react-scripts version to v4.0.0 🎉

Tested with league-web
just to keep track: there were a few minor conflicts in the following files:
- package.json
- packages/react-scripts/package.json
- packages/react-scripts/config/webpack.config.js
- azure-pipelines.yml

Reference to this detailed guide we have 😄 https://everlong.atlassian.net/wiki/spaces/TECH/pages/780567565/League+s+Create+React+App+React+Scripts+fork

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

Bumps [acorn](https://github.com/acornjs/acorn) from 6.4.0 to 6.4.1. - [Release notes](https://github.com/acornjs/acorn/releases) - [Commits](acornjs/acorn@6.4.0...6.4.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Passing an array with a single entry is not equivalent. This causes Webpack to generate another wrapper module around the entry. This is just unnecessary overhead and bytes.

See facebook#7790 for a previous similar PR.

This reverts commit c03bb36.

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

…k#8845)

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

- babel-plugin-named-asset-import@0.3.7 - babel-preset-react-app@10.0.0 - confusing-browser-globals@1.0.10 - cra-template-typescript@1.1.0 - cra-template@1.1.0 - create-react-app@4.0.0 - eslint-config-react-app@6.0.0 - react-app-polyfill@2.0.0 - react-dev-utils@11.0.0 - react-error-overlay@6.0.8 - react-scripts@4.0.0

panbenson · 2020-11-18T19:29:11Z

Update: Looks like theres quite a few changes needed to have this change in league-web. i'll get back to this some other time but will document what i find

theres new linting stuff that breaks the build:prod and affects like a million files
- i.e. react/prop-types, jsx-a11y/label-has-associated-control, react/destructuring-assignment, react/prop-types, etc.
storybook needs to be fixed
- Storyshot depends on require.requireActual which has removed from Jest 26 (though i haven't played with downgrading to jest 25 for our CRA fork)
- i tried to updated to storybook 6.0 but quite a few other things break (something with snapshotWithOptions in initiStoryshots)
  - withA11y decorator is removed
  - argument for the addDecorator callback is now a react element instead of a function
SVG imports to be updates (thanks for catching this @nicolechung)
- i.e. all imports like import { ReactComponent as MoneyBag } from './assets/money-bag-dollar.svg'; needs to be import MoneyBag from './assets/money-bag-dollar.svg';

panbenson · 2020-11-19T21:22:51Z

package.json

@@ -31,7 +31,7 @@
    "get-port": "^5.1.1",
    "globby": "^11.0.1",
    "husky": "^4.3.0",
-    "jest": "26.6.0",


Jest 26 breaks storybook 5, so downgrading to jest 25. Updating storybook was way too much to include at once 😅

panbenson · 2020-11-19T21:29:07Z

packages/react-scripts/config/webpack.config.js

-          },
-        },
-      }),
+      // START: EVERLONG CHANGES


I decided to leave the linting out for now, especially since we have the pre-commit linting on league-web. This linting lints everything and runs on both yarn build and yarn start, which is a pain because it takes a really long time. Plus, no linting errors are reported currently when we run yarn build:prod

for reference: yarn build:prod

took 243s with react-scripts v4

took 374s with our current react-scripts

panbenson · 2020-11-19T21:30:33Z

packages/react-scripts/package.json

@@ -89,7 +89,8 @@
    "webpack": "4.44.2",
    "webpack-dev-server": "3.11.0",
    "webpack-manifest-plugin": "2.2.0",
-    "workbox-webpack-plugin": "5.1.4"
+    "workbox-webpack-plugin": "5.1.4",
+    "typescript": "3.9.7"


this is another hack which lets me compile instead of getting this error message:

Failed to load plugin '@typescript-eslint' declared in '.eslintrc » eslint-config-react-app#overrides[0]': Cannot find module 'typescript'

theinterned

the changes here LGTM – I'm about to test https://github.com/EverlongProject/league-web/pull/4702 now.

foreverhomes

Same, nice!

nicolechung · 2020-11-23T14:43:01Z

error puppeteer@3.3.0: The engine "node" is incompatible with this module. Expected version ">=10.18.1". Got "10.16.3"
error Found incompatible module.

Did anyone else get this error on yarn ing?

panbenson · 2020-11-23T14:48:31Z

error puppeteer@3.3.0: The engine "node" is incompatible with this module. Expected version ">=10.18.1". Got "10.16.3"
error Found incompatible module.

Did anyone else get this error on yarn ing?

I needed to do nvm use 10.18.1 to get the packages to install

nicolechung · 2020-11-23T14:56:39Z

I needed to do nvm use 10.18.1 to get the packages to install

This worked for me! Although I think it might present a problem as we are forcing people to use 10.16 on League-web, we might have to look into updating the env/direnv settings on league-web

MichaelDeBoey and others added 30 commits March 24, 2020 09:10

Update template tests (facebook#8705)

79dbc33

Bump TypeScript template to 3.8 (facebook#8713)

edc671e

Add .cjs and .mjs files support to test runner (facebook#8768)

bc41892

Use simplified import of @testing-library/jest-dom (facebook#8763)

56d34c0

Include absoluteRuntime in babel preset docs (facebook#5847)

c7352c7

Specify what files are served form a bare local copy (facebook#8749)

4cbb003

fix: handle templates without main package field (facebook#8734)

e0b179c

Add experimental react-refresh support (facebook#8582)

c5b96c2

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

Add setupTests.js to the list of generated files (facebook#8791)

53cace5

Simplify wording in setting-up-your-editor.md (facebook#8684)

f0f4d5b

Update url to see prettier in action (facebook#8610)

d80e533

Don't use webpack multi entry unnecessarily (facebook#8834)

e89f153

Passing an array with a single entry is not equivalent. This causes Webpack to generate another wrapper module around the entry. This is just unnecessary overhead and bytes.

Widen eslint-config-react-app peer dependency versions (facebook#8892)

855a984

See facebook#7790 for a previous similar PR.

Revert "Replace favicon in templates (facebook#8194)" (facebook#8925)

3771237

This reverts commit c03bb36.

Minor/patch dependency upgrades (facebook#8947)

9cc1bdf

Upgrade to Jest 25 (facebook#8362)

9904075

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

Drop Node 8 support (facebook#8948)

8b0d21f

Bump React Hooks ESLint plugin to 4.0.0 (facebook#8939)

fa93437

Update build script deployment URL (facebook#8651)

99f1b6b

Do not check for interactive session to shut down dev server (faceboo…

2975939

…k#8845)

Support source maps for scss in dev environments (facebook#8638)

b37cff9

Skip stdin resuming to support lerna parallel (facebook#8700)

790fba9

Set resetMocks to true by default in jest config (facebook#7899)

4974a20

Add import/no-anonymous-default-export lint rule (facebook#8926)

3c2f2d4

Upgrade testing-library packages (facebook#8406)

5d437b8

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

Bump style-loader to 1.2.1 (facebook#8891)

5a019e6

Support devDependencies in templates (facebook#8838)

2473a73

fix react-refresh babel plugin not applied (facebook#8952)

62e8e3d

Add a VSCode tip in the CSS reset section (facebook#8246)

6a7aaa2

MichaelDeBoey and others added 14 commits October 22, 2020 15:32

feat: Update all dependencies (facebook#9857)

fe785b2

Co-authored-by: Ian Schmitz <ianschmitz@gmail.com>

New JSX Transform opt out (facebook#9861)

e63de79

Use new JSX setting with TypeScript 4.1.0 (facebook#9734)

d61347d

Upgrade to React 17 (facebook#9863)

4bc639c

Prepare 4.0.0 alpha release

f2aef41

Pass JSX runtime setting to Babel preset in Jest config (facebook#9865)

2b1161b

Prepare 4.0.0 release

014ca01

Update CHANGELOG

af616ab

Add link to Open Collective (facebook#9864)

523b416

Update CHANGELOG

95265c3

Update react dom in error overlay

d23d615

Prepare 4.0.0 release

88ca4f6

Merge tag 'v4.0.0' into merge-v4.0.0

70abed2

panbenson self-assigned this Nov 18, 2020

fix dependencies

6be2131

panbenson commented Nov 19, 2020

View reviewed changes

theinterned approved these changes Nov 19, 2020

View reviewed changes

theinterned changed the title ~~Update to v4.0.0~~ [FRONTEND-191] Update to v4.0.0 Nov 19, 2020

foreverhomes approved these changes Nov 20, 2020

View reviewed changes

fix all the tests 😅

612af12

include yarn lock

3b8f28a

panbenson merged commit 470c8f6 into main Nov 26, 2020

panbenson deleted the merge-v4.0.0 branch November 26, 2020 16:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FRONTEND-191] Update to v4.0.0 #29

[FRONTEND-191] Update to v4.0.0 #29

panbenson commented Nov 18, 2020

panbenson commented Nov 18, 2020

panbenson Nov 19, 2020 •

edited

Loading

panbenson Nov 19, 2020

panbenson Nov 19, 2020

theinterned left a comment

foreverhomes left a comment

nicolechung commented Nov 23, 2020

panbenson commented Nov 23, 2020

nicolechung commented Nov 23, 2020

[FRONTEND-191] Update to v4.0.0 #29

[FRONTEND-191] Update to v4.0.0 #29

Conversation

panbenson commented Nov 18, 2020

panbenson commented Nov 18, 2020

panbenson Nov 19, 2020 • edited Loading

Choose a reason for hiding this comment

panbenson Nov 19, 2020

Choose a reason for hiding this comment

panbenson Nov 19, 2020

Choose a reason for hiding this comment

theinterned left a comment

Choose a reason for hiding this comment

foreverhomes left a comment

Choose a reason for hiding this comment

nicolechung commented Nov 23, 2020

panbenson commented Nov 23, 2020

nicolechung commented Nov 23, 2020

panbenson Nov 19, 2020 •

edited

Loading