feat(connect): add temporal functions #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3799 +/- ##
==========================================
- Coverage 77.82% 76.61% -1.21%
==========================================
Files 745 746 +1
Lines 94416 98721 +4305
==========================================
+ Hits 73480 75636 +2156
- Misses 20936 23085 +2149
|
rchowell
approved these changes
Feb 12, 2025
Comment on lines
+56
to
+60
| parent.add_fn("to_date", UnaryFunction(|arg| arg.cast(&DataType::Date))); | ||
| parent.add_fn( | ||
| "to_timestamp", | ||
| UnaryFunction(|arg| arg.cast(&DataType::Timestamp(TimeUnit::Milliseconds, None))), | ||
| ); |
There was a problem hiding this comment.
I'm curious if the semantics of our cast are actually the same, cast rules are rightfully prescriptive but we/spark could do anything with a to_type function. No need to update here – am mostly curious if these accurate.
There was a problem hiding this comment.
yeah, I'm not entirely sure if this is correct (according to spark). AFAIK, most to_timestamp methods use milliseconds as the default, and i couldn't find anything in the spark docs saying otherwise
jessie-young
pushed a commit
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.