Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nulls first kernels #3789

Merged

Conversation

universalmind303
Copy link
Contributor

No description provided.

Copy link

codspeed-hq bot commented Feb 11, 2025

CodSpeed Performance Report

Merging #3789 will improve performances by 12.19%

Comparing universalmind303:nulls-first-kernels (a7dcbad) with main (e5ff39f)

Summary

⚡ 1 improvements
✅ 26 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
test_count[1 Small File] 3.8 ms 3.4 ms +12.19%

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 93.93939% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.90%. Comparing base (2063d21) to head (a7dcbad).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/daft-core/src/array/ops/sort.rs 83.33% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3789      +/-   ##
==========================================
- Coverage   77.88%   76.90%   -0.99%     
==========================================
  Files         741      744       +3     
  Lines       93878    96922    +3044     
==========================================
+ Hits        73116    74534    +1418     
- Misses      20762    22388    +1626     
Files with missing lines Coverage Δ
daft/dataframe/dataframe.py 85.25% <100.00%> (-0.27%) ⬇️
daft/execution/execution_step.py 89.65% <100.00%> (+0.01%) ⬆️
daft/execution/physical_plan.py 94.35% <ø> (ø)
...core/src/array/ops/arrow2/sort/primitive/common.rs 100.00% <100.00%> (ø)
...ore/src/array/ops/arrow2/sort/primitive/indices.rs 100.00% <100.00%> (ø)
src/daft-core/src/series/ops/sort.rs 62.06% <ø> (-2.45%) ⬇️
src/daft-core/src/array/ops/sort.rs 76.96% <83.33%> (+0.17%) ⬆️

... and 44 files with indirect coverage changes

@universalmind303 universalmind303 merged commit ca36593 into Eventual-Inc:main Feb 12, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants