Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: Predicate short circuit #3776

Conversation

desmondcheongzx
Copy link
Contributor

No description provided.

Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #3776 will degrade performances by 31.56%

Comparing desmondcheongzx:predicate-short-circuit (7f5d91d) with main (d40aef8)

Summary

⚡ 2 improvements
❌ 2 regressions
✅ 23 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iter_rows_first_row[100 Small Files] 198.4 ms 265.9 ms -25.38%
test_show[100 Small Files] 16.4 ms 24 ms -31.56%
test_tpch[1-in-memory-native-6] 28.9 ms 24.1 ms +20.06%
test_tpch_sql[1-in-memory-native-6] 29.2 ms 24.6 ms +18.65%

@desmondcheongzx desmondcheongzx changed the title predicate short circuit perf: Predicate short circuit Feb 6, 2025
@github-actions github-actions bot added the perf label Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.82%. Comparing base (d40aef8) to head (7f5d91d).
Report is 21 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3776      +/-   ##
==========================================
+ Coverage   76.30%   77.82%   +1.52%     
==========================================
  Files         736      737       +1     
  Lines       93557    93378     -179     
==========================================
+ Hits        71391    72676    +1285     
+ Misses      22166    20702    -1464     
Files with missing lines Coverage Δ
src/daft-table/src/lib.rs 84.56% <100.00%> (+0.32%) ⬆️

... and 20 files with indirect coverage changes

@samster25 samster25 closed this Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants