Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add scarf analytics #3773

Open
wants to merge 37 commits into
base: main
Choose a base branch
from
Open

docs: add scarf analytics #3773

wants to merge 37 commits into from

Conversation

ccmao1130
Copy link
Contributor

@ccmao1130 ccmao1130 commented Feb 6, 2025

Added Scarf pixels and custom telemetry (See: https://docs.scarf.sh/custom-telemetry/) for collecting anonymous user data.

Custom Telemetry has been added to track each runner

Current locations where pixels have been added:

  • Daft repo README
  • Daft user guide
  • Daft API Docs

@github-actions github-actions bot added the docs label Feb 6, 2025
Copy link

codspeed-hq bot commented Feb 6, 2025

CodSpeed Performance Report

Merging #3773 will degrade performances by 22.95%

Comparing docs-scarf (86b3377) with main (ca36593)

Summary

❌ 1 regressions
✅ 26 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
test_iter_rows_first_row[100 Small Files] 167 ms 216.7 ms -22.95%

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.83%. Comparing base (ca36593) to head (86b3377).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3773   +/-   ##
=======================================
  Coverage   77.82%   77.83%           
=======================================
  Files         745      746    +1     
  Lines       94416    94440   +24     
=======================================
+ Hits        73480    73505   +25     
+ Misses      20936    20935    -1     
Files with missing lines Coverage Δ
daft/__init__.py 23.68% <ø> (ø)
daft/context.py 84.14% <100.00%> (+0.81%) ⬆️
daft/scarf_telemetry.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ccmao1130 ccmao1130 requested a review from jaychia February 7, 2025 02:32
daft/scarf_telemetry.py Outdated Show resolved Hide resolved
@ccmao1130 ccmao1130 requested a review from raunakab February 10, 2025 20:46
daft/scarf_telemetry.py Outdated Show resolved Hide resolved
daft/scarf_telemetry.py Outdated Show resolved Hide resolved
daft/scarf_telemetry.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants