Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Get native execution enablement from DAFT_RUNNER #3409

Conversation

desmondcheongzx
Copy link
Contributor

We added a new DAFT_RUNNER environment variable, so we should use this environment variable when creating the execution configuration.

@github-actions github-actions bot added the enhancement New feature or request label Nov 25, 2024
Copy link

codspeed-hq bot commented Nov 25, 2024

CodSpeed Performance Report

Merging #3409 will degrade performances by 27.43%

Comparing desmondcheongzx:add-daft-runner-check-to-context (97c32e3) with main (8052de7)

Summary

❌ 2 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main desmondcheongzx:add-daft-runner-check-to-context Change
test_count[1 Small File] 3.3 ms 3.7 ms -10.18%
test_iter_rows_first_row[100 Small Files] 230.4 ms 317.5 ms -27.43%

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.36%. Comparing base (8052de7) to head (97c32e3).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3409   +/-   ##
=======================================
  Coverage   77.35%   77.36%           
=======================================
  Files         684      684           
  Lines       83627    83635    +8     
=======================================
+ Hits        64688    64701   +13     
+ Misses      18939    18934    -5     
Files with missing lines Coverage Δ
src/common/daft-config/src/lib.rs 81.69% <100.00%> (+1.69%) ⬆️

... and 3 files with indirect coverage changes

---- 🚨 Try these New Features:

@desmondcheongzx desmondcheongzx merged commit 11c46a9 into Eventual-Inc:main Nov 25, 2024
41 of 42 checks passed
@desmondcheongzx desmondcheongzx deleted the add-daft-runner-check-to-context branch November 25, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants