Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable throwing compiler errors for obsolete code #291

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Disable throwing compiler errors for obsolete code #291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...EventStore.Client.PersistentSubscriptions/EventStorePersistentSubscriptionsClient.Read.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ partial class EventStorePersistentSubscriptionsClient {
/// <exception cref="ArgumentNullException"></exception>
/// <exception cref="ArgumentException"></exception>
/// <exception cref="ArgumentOutOfRangeException"></exception>
[Obsolete("SubscribeAsync is no longer supported. Use SubscribeToStream with manual acks instead.", true)]
[Obsolete("SubscribeAsync is no longer supported. Use SubscribeToStream with manual acks instead.", false)]
public async Task<PersistentSubscription> SubscribeAsync(string streamName, string groupName,
Func<PersistentSubscription, ResolvedEvent, int?, CancellationToken, Task> eventAppeared,
Action<PersistentSubscription, SubscriptionDroppedReason, Exception?>? subscriptionDropped = null,
Expand All @@ -32,7 +32,7 @@ public async Task<PersistentSubscription> SubscribeAsync(string streamName, stri
/// <exception cref="ArgumentNullException"></exception>
/// <exception cref="ArgumentException"></exception>
/// <exception cref="ArgumentOutOfRangeException"></exception>
[Obsolete("SubscribeToStreamAsync is no longer supported. Use SubscribeToStream with manual acks instead.", true)]
[Obsolete("SubscribeToStreamAsync is no longer supported. Use SubscribeToStream with manual acks instead.", false)]
public async Task<PersistentSubscription> SubscribeToStreamAsync(string streamName, string groupName,
Func<PersistentSubscription, ResolvedEvent, int?, CancellationToken, Task> eventAppeared,
Action<PersistentSubscription, SubscriptionDroppedReason, Exception?>? subscriptionDropped = null,
Expand Down Expand Up @@ -102,7 +102,7 @@ public PersistentSubscriptionResult SubscribeToStream(string streamName, string
/// <summary>
/// Subscribes to a persistent subscription to $all. Messages must be manually acknowledged
/// </summary>
[Obsolete("SubscribeToAllAsync is no longer supported. Use SubscribeToAll with manual acks instead.", true)]
[Obsolete("SubscribeToAllAsync is no longer supported. Use SubscribeToAll with manual acks instead.", false)]
public async Task<PersistentSubscription> SubscribeToAllAsync(string groupName,
Func<PersistentSubscription, ResolvedEvent, int?, CancellationToken, Task> eventAppeared,
Action<PersistentSubscription, SubscriptionDroppedReason, Exception?>? subscriptionDropped = null,
Expand Down
4 changes: 2 additions & 2 deletions src/EventStore.Client.Streams/EventStoreClient.Subscriptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public partial class EventStoreClient {
/// <param name="userCredentials">The optional user credentials to perform operation with.</param>
/// <param name="cancellationToken">The optional <see cref="System.Threading.CancellationToken"/>.</param>
/// <returns></returns>
[Obsolete("SubscribeToAllAsync is no longer supported. Use SubscribeToAll instead.", true)]
[Obsolete("SubscribeToAllAsync is no longer supported. Use SubscribeToAll instead.", false)]
public Task<StreamSubscription> SubscribeToAllAsync(
FromAll start,
Func<StreamSubscription, ResolvedEvent, CancellationToken, Task> eventAppeared,
Expand Down Expand Up @@ -68,7 +68,7 @@ public StreamSubscriptionResult SubscribeToAll(
/// <param name="userCredentials">The optional user credentials to perform operation with.</param>
/// <param name="cancellationToken">The optional <see cref="System.Threading.CancellationToken"/>.</param>
/// <returns></returns>
[Obsolete("SubscribeToStreamAsync is no longer supported. Use SubscribeToStream instead.", true)]
[Obsolete("SubscribeToStreamAsync is no longer supported. Use SubscribeToStream instead.", false)]
public Task<StreamSubscription> SubscribeToStreamAsync(string streamName,
FromStream start,
Func<StreamSubscription, ResolvedEvent, CancellationToken, Task> eventAppeared,
Expand Down
Loading