-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV-92 - Add missing option tlsCAFile #281
Merged
josephcummings
merged 11 commits into
master
from
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
Feb 26, 2024
Merged
DEV-92 - Add missing option tlsCAFile #281
josephcummings
merged 11 commits into
master
from
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
Feb 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1am
force-pushed
the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
2 times, most recently
from
February 6, 2024 08:59
b5ca231
to
d87035f
Compare
w1am
force-pushed
the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
from
February 6, 2024 10:08
d87035f
to
1519e92
Compare
…issing-certificate-parameters
w1am
force-pushed
the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
2 times, most recently
from
February 6, 2024 10:25
195bc61
to
022ec41
Compare
w1am
force-pushed
the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
from
February 6, 2024 14:23
7f3a7f2
to
fc9eec5
Compare
josephcummings
suggested changes
Feb 6, 2024
src/EventStore.Client/EventStoreClientSettings.ConnectionString.cs
Outdated
Show resolved
Hide resolved
src/EventStore.Client/EventStoreClientSettings.ConnectionString.cs
Outdated
Show resolved
Hide resolved
src/EventStore.Client/EventStoreClientSettings.ConnectionString.cs
Outdated
Show resolved
Hide resolved
test/EventStore.Client.Streams.Tests/Append/append_to_stream_with_tls_ca_file.cs
Outdated
Show resolved
Hide resolved
w1am
force-pushed
the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
from
February 7, 2024 06:29
c721648
to
a248e17
Compare
- Remove connectivity settings alias - Change type of TlsCaFile - Add custom exception - Cleanup tests - Add gencert script for Windows, MacOS and WSL - Add handler in ChannelFactory
w1am
force-pushed
the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
from
February 7, 2024 06:41
a248e17
to
a259f93
Compare
josephcummings
suggested changes
Feb 7, 2024
src/EventStore.Client/EventStoreClientSettings.ConnectionString.cs
Outdated
Show resolved
Hide resolved
josephcummings
previously approved these changes
Feb 7, 2024
RagingKore
previously approved these changes
Feb 26, 2024
josephcummings
changed the title
Add missing option tlsCAFile
DEV-92 - Add missing option tlsCAFile
Feb 26, 2024
…issing-certificate-parameters
josephcummings
dismissed stale reviews from RagingKore and themself
via
February 26, 2024 13:42
c0e16a2
josephcummings
approved these changes
Feb 26, 2024
RagingKore
approved these changes
Feb 26, 2024
josephcummings
deleted the
w1am/dev-92-net-client-connection-string-missing-certificate-parameters
branch
February 26, 2024 14:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added: Add missing option tlsCAFile