Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV-92 - Add missing option tlsCAFile #281

Conversation

w1am
Copy link
Contributor

@w1am w1am commented Feb 5, 2024

Added: Add missing option tlsCAFile

Copy link

linear bot commented Feb 5, 2024

@w1am w1am force-pushed the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch 2 times, most recently from b5ca231 to d87035f Compare February 6, 2024 08:59
@w1am w1am marked this pull request as draft February 6, 2024 09:49
@w1am w1am force-pushed the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch from d87035f to 1519e92 Compare February 6, 2024 10:08
@w1am w1am force-pushed the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch 2 times, most recently from 195bc61 to 022ec41 Compare February 6, 2024 10:25
@w1am w1am force-pushed the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch from 7f3a7f2 to fc9eec5 Compare February 6, 2024 14:23
@w1am w1am marked this pull request as ready for review February 6, 2024 15:38
@w1am w1am force-pushed the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch from c721648 to a248e17 Compare February 7, 2024 06:29
- Remove connectivity settings alias
- Change type of TlsCaFile
- Add custom exception
- Cleanup tests
- Add gencert script for Windows, MacOS and WSL
- Add handler in ChannelFactory
@w1am w1am force-pushed the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch from a248e17 to a259f93 Compare February 7, 2024 06:41
@w1am w1am requested a review from josephcummings February 7, 2024 07:25
gencert.sh Outdated Show resolved Hide resolved
test/EventStore.Client.Tests/ConnectionStringTests.cs Outdated Show resolved Hide resolved
josephcummings
josephcummings previously approved these changes Feb 7, 2024
RagingKore
RagingKore previously approved these changes Feb 26, 2024
@josephcummings josephcummings changed the title Add missing option tlsCAFile DEV-92 - Add missing option tlsCAFile Feb 26, 2024
@josephcummings josephcummings dismissed stale reviews from RagingKore and themself via c0e16a2 February 26, 2024 13:42
@josephcummings josephcummings merged commit e65f330 into master Feb 26, 2024
59 checks passed
@josephcummings josephcummings deleted the w1am/dev-92-net-client-connection-string-missing-certificate-parameters branch February 26, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants