Skip to content
This repository has been archived by the owner on Mar 10, 2023. It is now read-only.

fix: use NoEmitOnErrorsPlugin instead of deprecated NoErrorsPlugin #246

Merged
merged 1 commit into from
Feb 20, 2017

Conversation

alepee
Copy link
Member

@alepee alepee commented Feb 20, 2017

NoErrorsPlugin is now deprecated as describe in issue webpack/webpack#3179

We now use NoEmitOnErrorsPlugin instead

@alepee alepee added the bug label Feb 20, 2017
@alepee alepee added this to the 1.0 milestone Feb 20, 2017
Copy link
Contributor

@LucasPerso LucasPerso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Webpack for clarifying this plugin name !

@alepee alepee merged commit 229d8d3 into master Feb 20, 2017
@johangirod johangirod mentioned this pull request Feb 20, 2017
@christophehurpeau christophehurpeau deleted the deprecated-NoErrorsPlugin-to-NoEmitOnErrorsPlugin branch February 20, 2017 15:02
AdamJo added a commit to AdamJo/preact-boilerplate that referenced this pull request Mar 4, 2017
Evaneos/vitaminjs#246

NoErrorsPlugin has been deprecated and renamed NoEmitOnErrorsPlugin to
be clearer
developit pushed a commit to developit/preact-boilerplate that referenced this pull request Apr 25, 2017
* add /.vscode config to .gitignore

* package() update webpack dependencies

* config() remove empty stream extensions

https://webpack.js.org/guides/migrating/#resolve-extensions

* config() modulesDirectories renamed to modules

https://webpack.js.org/guides/migrating/#resolve-root-resolve-fallback-resolve-modulesdirectories

* config() refactor loadesr to webpack 2, see details

https://webpack.js.org/guides/migrating/#module-loaders-is-now-module-rules

- loaders has been renamed to rules
- except for babel-loader
- preLoaders now use `enforce: 'pre'`
- extract-text-webpack-plugin:
- fallbackloader => fallback
- moved each loader to its own object
- move `postcss` options into postcss-loader options

* config() NoErrorsPlugin deprecated -> NoEmitOnErrorsPlugin

Evaneos/vitaminjs#246

NoErrorsPlugin has been deprecated and renamed NoEmitOnErrorsPlugin to
be clearer

* config() uglifyJsPlugin warnings message is false by default

https://webpack.js.org/guides/migrating/#uglifyjsplugin-warnings

* config() devServer colors has been deprecated

if you try to fun the code with colors in it you get an error that
colors is not in the API scheme

Could not find documentation for this change.

* package() update serve to ^4.0.0

* package() update extract-text-webpack-plugin

* chore(package) update dependencies

* chore(test): update karma configuration

* chore(upstream) fix absolute path for favicon

* chore(packages) update dependencies

* fix(webpack) remove warnings for tree shaken code

examples of warnings being silenced:
WARNING in bundle.js from UglifyJs
Condition always true [bundle.js:74,5]
Condition always true [bundle.js:565,2]
Collapsing variable diff [bundle.js:620,8]
Condition always true [bundle.js:1292,4]
Condition always false [bundle.js:1297,4]
Dropping unreachable code [bundle.js:1299,1]
Dropping unused variable appCacheIframe [bundle.js:1331,4]

and

WARNING in __offline_serviceworker from UglifyJs
Collapsing variable fetching [__offline_serviceworker:433,13]
Collapsing variable loader [__offline_serviceworker:581,10]
Dropping unused variable STORED_DATA_KEY [__offline_serviceworker:109,6]
Collapsing variable hasQuery [__offline_serviceworker:640,18]
Dropping unused function getClientsURLs [__offline_serviceworker:643,9]

* fix(config) redo'n merge into master

* chore(package) update packages

* config(uglifyJS) add more constraints to uglifyJS

* chore(package) remove Lazy Parser due to error in webpack 2 build

webpack/webpack#3980

* chore(package) WIP upgrade to preact > 8.0.

Link currently does not work when compiled.

* fix(Package) upgrading to 2.4.5 fixes link issue

preactjs/preact-router#172

* chore(package) update dependencies

* chore(packages) update dependencies

* chore(package) remove unused package

missed isparta-loader in previous merge.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants