This repository has been archived by the owner on Mar 10, 2023. It is now read-only.
Action dispatcher breaking #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucasPerso
reviewed
Feb 17, 2017
API.md
Outdated
| The actionDispatcher is passed the node http request object, the dispatch function, and getState | ||
| as parameters. It's expected to return something that can be yield (Promise, Generator, etc..) or nothing. If it returns a yieldable, then the server will wait for its completion before continuing. | ||
| Path to a file exporting an createInitAction. Useful for populating the store on the server before rendering. | ||
| The createInitAction is passed the node http request object as parameter. |
There was a problem hiding this comment.
Koa2 request object is passed as a parameter to createInitiAction
API.md
Outdated
| as parameters. It's expected to return something that can be yield (Promise, Generator, etc..) or nothing. If it returns a yieldable, then the server will wait for its completion before continuing. | ||
| Path to a file exporting an createInitAction. Useful for populating the store on the server before rendering. | ||
| The createInitAction is passed the node http request object as parameter. | ||
| It's expected to return an action or nothing. The action can be a thunk. |
There was a problem hiding this comment.
It must return and action or nothing
d47b194 to
7062b3a
Compare
…turned result of server.createInitAction BREAKING: you must use createInitAction instead of actionDispatcher
7062b3a to
fb121a3
Compare
johangirod
approved these changes
Feb 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.