Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify command #3

Merged
merged 5 commits into from
Nov 22, 2022
Merged

Add verify command #3

merged 5 commits into from
Nov 22, 2022

Conversation

RobertRosca
Copy link
Member

PR adds a verify command which reads the spack install manifest files inside a view and checks that all of the files which were installed by spack are still symlinks pointing to the correct locations.

If they are not, then a --fix flag can be passed to replace the files with the correct symlinks.

Todo:

  • Testing
  • Update to readme/docs

@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Base: 93.02% // Head: 86.92% // Decreases project coverage by -6.10% ⚠️

Coverage data is based on head (c390494) compared to base (e3a9906).
Patch coverage: 42.10% of modified lines in pull request are covered.

❗ Current head c390494 differs from pull request most recent head bc15120. Consider uploading reports for the commit bc15120 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #3      +/-   ##
==========================================
- Coverage   93.02%   86.92%   -6.11%     
==========================================
  Files          13       14       +1     
  Lines         416      459      +43     
==========================================
+ Hits          387      399      +12     
- Misses         29       60      +31     
Impacted Files Coverage Δ
src/pyvarium/installers/base.py 80.59% <0.00%> (-1.23%) ⬇️
src/pyvarium/installers/spack.py 80.85% <31.81%> (-15.31%) ⬇️
src/pyvarium/cli/verify.py 33.33% <33.33%> (ø)
src/pyvarium/cli/__init__.py 82.00% <100.00%> (+0.36%) ⬆️
src/pyvarium/cli/new.py 100.00% <100.00%> (+4.34%) ⬆️
src/pyvarium/config.py 92.72% <100.00%> (ø)
src/pyvarium/installers/pipenv.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2022

This pull request fixes 1 alert when merging c390494 into 4fea4bb - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@RobertRosca RobertRosca merged commit 67afae9 into main Nov 22, 2022
@RobertRosca RobertRosca deleted the feat/verify-commnand branch November 22, 2022 15:24
@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2022

This pull request fixes 1 alert when merging bc15120 into 4fea4bb - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant