Reject unsupported key types instead of failing #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently russh doesn't support ED25519/ECDSA-SK keys, but OpenSSH will attempt to use them anyway. Key parse will then fail, killing the session. This should be treated as-if auth_publickey_offered rejects the key.
|
LGTM, thank you! @all-contributors add @nbdd0121 for code |
|
I've put up a pull request to add @nbdd0121! 🎉 |
Eugeny
pushed a commit
that referenced
this pull request
Sep 22, 2024
Adds @nbdd0121 as a contributor for code. This was requested by Eugeny [in this comment](#352 (comment)) [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
gleason-m
added a commit
to gleason-m/russh
that referenced
this pull request
Feb 6, 2025
This reverts commit f587d13.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently russh doesn't support ED25519/ECDSA-SK keys, but OpenSSH will attempt to use them anyway. Key parse will then fail, killing the session.
This should be treated as-if auth_publickey_offered rejects the key.