Scrollbar size settings in preference implemented #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
141
to
142
| verticalScrollbarSize: 10, | ||
| horizontalScrollbarSize: 10 |
There was a problem hiding this comment.
Why are we removing the defaults?
When the horizontal and vertical scrollbar sizes are adjusted in setting (in the preference menu), it now apply the scrollbar height or width in the editor.
vince-fugnitto
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
When the horizontal and vertical scrollbar sizes are adjusted in setting, it should reflect on the scrollbar height in the editor.
Closes eclipse-theia#11732
How to test
**please note these change only apply to the scrollbar of the editor.
Issue.11732.-before.corrections.mp4
Issue.11732.-.after.corrections.mp4
Review checklist
review guidelines](https://github.com/theia-ide/theia/blob/master/doc/pull-requests.md#requesting-a-review)
Reminder for reviewers