Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(block): add accessible label for slotted controls #9502

Merged
merged 2 commits into from
Jun 6, 2024
Merged

fix(block): add accessible label for slotted controls #9502

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f5ed3a
fix(block): add aria-describedby for slotted controls. #8037
driskull Jun 3, 2024
ac33969
Update packages/calcite-components/src/components/block/block.tsx
driskull Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/block/block.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ export class Block
headerContent
)}
{hasControl ? (
<div class={CSS.controlContainer}>
<div aria-labelledby={IDS.header} class={CSS.controlContainer}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the control actually labeled by the entire header? When I run this through VO it works but UX wise I'm not 100% sure it makes sense. The entire header includes icons, heading, and description. That's potentially a lot of content to label a control.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its just the title and icon.

calcite-design-system/packages/calcite-components/src/components/block/block.tsx

Lines 342 to 347 in ac33969

const headerContent = (
<header class={CSS.header} id={IDS.header}>
{this.renderIcon()}
{this.renderTitle()}
</header>
);

<slot name={SLOTS.control} />
</div>
) : null}
Expand Down
Loading