Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(modal): add token theming tests #9447

Merged
merged 3 commits into from
May 30, 2024
Merged

test(modal): add token theming tests #9447

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
789b6ac
test(modal): add token theming tests
Elijbet May 29, 2024
7129ea2
accent color tests
Elijbet May 30, 2024
5f40450
cleanup
Elijbet May 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
140 changes: 137 additions & 3 deletions packages/calcite-components/src/components/modal/modal.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
import { E2EPage, newE2EPage } from "@stencil/core/testing";
import { focusable, hidden, openClose, renders, slots, t9n } from "../../tests/commonTests";
import { focusable, hidden, openClose, renders, slots, t9n, themed } from "../../tests/commonTests";
import { html } from "../../../support/formatting";
import { GlobalTestProps, isElementFocused, skipAnimations } from "../../tests/utils";
import { ComponentTestTokens } from "../../tests/commonTests/themed";
import { CSS, SLOTS } from "./resources";

describe("calcite-modal", () => {
Expand Down Expand Up @@ -610,7 +611,7 @@ describe("calcite-modal", () => {
});
const scrimStyles = await page.evaluate(() => {
const scrim = document.querySelector("calcite-modal").shadowRoot.querySelector(".scrim");
return window.getComputedStyle(scrim).getPropertyValue("--calcite-scrim-background");
return window.getComputedStyle(scrim).getPropertyValue("--calcite-scrim-background-color");
});
expect(scrimStyles.trim()).toEqual("rgba(0, 0, 0, 0.85)");
});
Expand All @@ -632,7 +633,7 @@ describe("calcite-modal", () => {
});
const scrimStyles = await page.evaluate(() => {
const scrim = document.querySelector("calcite-modal").shadowRoot.querySelector(".scrim");
return window.getComputedStyle(scrim).getPropertyValue("--calcite-scrim-background");
return window.getComputedStyle(scrim).getPropertyValue("--calcite-scrim-background-color");
});
expect(scrimStyles).toEqual(overrideStyle);
});
Expand All @@ -657,3 +658,136 @@ describe("calcite-modal", () => {
expect(closeIcon).not.toBe(null);
});
});

describe("theme", () => {
const modalHTML = html`
<calcite-modal open>
<h3 slot="header">Slot for a header.</h3>
<div slot="content-top">Slot for a content-top.</div>
<div slot="content" style="height: 100px">
Lorem ipsum dolor sit amet, feugiat magna ut, posuere arcu. Curabitur varius erat ut suscipit convallis.
</div>
<div slot="content-bottom">Slot for a content-bottom.</div>
<calcite-button slot="primary" width="full">Button</calcite-button>
</calcite-modal>
`;
const modalBrandHTML = html`
<calcite-modal kind="brand" open>
<h3 slot="header">Slot for a header.</h3>
</calcite-modal>
`;
const modalDangerHTML = html`
<calcite-modal kind="danger" open>
<h3 slot="header">Slot for a header.</h3>
</calcite-modal>
`;
const modalInfoHTML = html`
<calcite-modal kind="info" open>
<h3 slot="header">Slot for a header.</h3>
</calcite-modal>
`;
const modalSuccessHTML = html`
<calcite-modal kind="success" open>
<h3 slot="header">Slot for a header.</h3>
</calcite-modal>
`;
const modalWarningHTML = html`
<calcite-modal kind="warning" open>
<h3 slot="header">Slot for a header.</h3>
</calcite-modal>
`;
describe("default", () => {
const tokens: ComponentTestTokens = {
"--calcite-modal-background-color": {
shadowSelector: `.${CSS.modal}`,
targetProp: "backgroundColor",
},
"--calcite-modal-border-color": {
shadowSelector: `.${CSS.container}`,
targetProp: "--calcite-internal-modal-border-color",
},
"--calcite-modal-close-button-background-color-hover": {
shadowSelector: `.${CSS.modal} .${CSS.close}`,
targetProp: "backgroundColor",
state: { hover: { attribute: "class", value: CSS.close } },
},
"--calcite-modal-close-button-background-color": {
shadowSelector: `.${CSS.modal} .${CSS.close}`,
targetProp: "backgroundColor",
},
"--calcite-modal-content-background-color": {
shadowSelector: `.${CSS.modal} .${CSS.content}`,
targetProp: "backgroundColor",
},
"--calcite-modal-content-padding": {
shadowSelector: `.${CSS.modal} .${CSS.content}`,
targetProp: "padding",
},
"--calcite-modal-content-space": {
shadowSelector: `.${CSS.modal} .${CSS.content}`,
targetProp: "padding",
},
"--calcite-modal-height": {
shadowSelector: `.${CSS.modal}`,
targetProp: "blockSize",
},
"--calcite-modal-shadow": {
shadowSelector: `.${CSS.modal}`,
targetProp: "boxShadow",
},
"--calcite-modal-text-color": {
shadowSelector: `.${CSS.modal}`,
targetProp: "color",
},
"--calcite-modal-width": {
shadowSelector: `.${CSS.modal}`,
targetProp: "inlineSize",
},
"--calcite-modal-scrim-background-color": {
shadowSelector: `.${CSS.scrim}`,
targetProp: "--calcite-scrim-background-color",
},
};
themed(async () => modalHTML, tokens);
});
describe("kindBrand", () => {
const tokens: ComponentTestTokens = {
"--calcite-modal-accent-color": {
targetProp: "--calcite-internal-modal-accent-color",
},
};
themed(async () => modalBrandHTML, tokens);
});
describe("dangerBrand", () => {
const tokens: ComponentTestTokens = {
"--calcite-modal-accent-color": {
targetProp: "--calcite-internal-modal-accent-color",
},
};
themed(async () => modalDangerHTML, tokens);
});
describe("infoBrand", () => {
const tokens: ComponentTestTokens = {
"--calcite-modal-accent-color": {
targetProp: "--calcite-internal-modal-accent-color",
},
};
themed(async () => modalInfoHTML, tokens);
});
describe("successBrand", () => {
const tokens: ComponentTestTokens = {
"--calcite-modal-accent-color": {
targetProp: "--calcite-internal-modal-accent-color",
},
};
themed(async () => modalSuccessHTML, tokens);
});
describe("warningBrand", () => {
const tokens: ComponentTestTokens = {
"--calcite-modal-accent-color": {
targetProp: "--calcite-internal-modal-accent-color",
},
};
themed(async () => modalWarningHTML, tokens);
});
});