Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(link): add token theming tests #9407

Merged
merged 2 commits into from
May 24, 2024
Merged

test(link): add token theming tests #9407

merged 2 commits into from
May 24, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented May 23, 2024

Related Issue: #7180

Summary

Add token theming tests for link.

@Elijbet Elijbet marked this pull request as draft May 23, 2024 22:38
@Elijbet Elijbet changed the base branch from main to epic/7180-component-tokens May 23, 2024 22:41
@Elijbet Elijbet marked this pull request as ready for review May 23, 2024 22:43
@Elijbet Elijbet changed the title Elijbet/token test link test(link): add token theming tests May 23, 2024
alisonailea
alisonailea approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

packages/calcite-components/src/components/link/link.e2e.ts Outdated Show resolved Hide resolved
jcfranco
jcfranco approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨🏆✨

@Elijbet
Copy link
Contributor Author

Elijbet commented May 23, 2024 •
edited
Loading

The PR doesn't address the underline token gradient. Looks like themed needs to be updated to handle that case.

  background-image: linear-gradient(currentColor, currentColor),
    linear-gradient(
      var(--calcite-link-underline-color-start, var(--calcite-color-brand-underline)),
      var(--calcite-link-underline-color-end, var(--calcite-color-brand-underline))
    );

@Elijbet Elijbet merged commit 1ca9a3e into epic/7180-component-tokens May 24, 2024
4 checks passed
@Elijbet Elijbet deleted the elijbet/token-test-link branch May 24, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

@jcfranco jcfranco jcfranco approved these changes

@benelan benelan Awaiting requested review from benelan

@driskull driskull Awaiting requested review from driskull

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elijbet @jcfranco @alisonailea