fix(handle): update for e2e theme test #9161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcfranco
approved these changes
Apr 22, 2024
| shadowSelector: `.${CSS.handle}`, | ||
| state: "focus", | ||
| }, | ||
| "--calcite-handle-background-color-selected": { |
There was a problem hiding this comment.
For clarity, I think this should go under a separate selected describe block. Handle doesn't have press-specific styling and this is implicitly interacting with the component to trigger selection.
| @@ -2103,7 +2103,9 @@ async function assertThemedProps(page: E2EPage, options: TestTarget): Promise<vo | |||
| await page.mouse.reset(); | |||
| await page.waitForChanges(); | |||
|
|
|||
| // eslint-disable-next-line @stencil-community/strict-boolean-conditions | |||
There was a problem hiding this comment.
Can you revert this before installing? It's only showing warnings and I've got a PR to disable this rule.
…onents into astump/7180-fix-handle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
update handle component