fix(action-menu): update component and add E2E tests #9065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 377dc68 Author: Ali Stump <astump@esri.com> Date: Wed Apr 3 15:34:57 2024 -0700 refactor(common): simplify theme tests to be more readable commit 6b78dfb Author: Ali Stump <astump@esri.com> Date: Mon Apr 1 15:10:11 2024 -0700 refactor: test utils to simplify assertThemedProps commit e777ea3 Author: Ali Stump <astump@esri.com> Date: Mon Apr 1 12:17:32 2024 -0700 docs: add jsdocs to common test utils commit c2244da Author: Ali Stump <astump@esri.com> Date: Mon Apr 1 12:03:21 2024 -0700 tests: test theme-ing for stateful tokens commit ec2ec64 Author: Ali Stump <astump@esri.com> Date: Wed Mar 27 12:26:56 2024 -0700 test: allow theme tests to penetrate subcomponent shadow dom commit 2e0e1d8 Author: Ali Stump <astump@esri.com> Date: Tue Mar 26 16:52:00 2024 -0700 chore: update common theme-ing tests commit e1d204f Author: Ali Stump <astump@esri.com> Date: Mon Mar 25 15:32:01 2024 -0700 chore(common): add non-color values for tokenList in themed commit 2a9472c Author: Ali Stump <astump@esri.com> Date: Mon Mar 25 15:27:59 2024 -0700 chore(common): add themed common test
…components into astump/7180-fix-action-menu # Conflicts: # packages/calcite-components/src/tests/commonTests.ts # packages/calcite-components/src/tests/utils.ts
driskull
reviewed
Apr 9, 2024
| @@ -323,9 +323,11 @@ export class ActionMenu implements LoadableComponent { | |||
| render(): VNode { | |||
| return ( | |||
| <Fragment> | |||
There was a problem hiding this comment.
Since a container is now added then this fragment is no longer necessary. Do we need the container with display:contents?
There was a problem hiding this comment.
Agreed to remove <Fragment>, but display:contents is needed to achieve the same layout. <Fragment> doesn't produce an element, so all children are directly under the host when rendered.
…components into astump/7180-fix-action-menu
jcfranco
approved these changes
Apr 18, 2024
| }, | ||
| } as const; | ||
| themed( | ||
| `<calcite-action-menu open> |
There was a problem hiding this comment.
Can you use the html tagged template function to help Prettier format embedded HTML?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Requires #9027 to be merged.