fix(action-bar): update tokens and e2e tests #9035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 6b78dfb Author: Ali Stump <astump@esri.com> Date: Mon Apr 1 15:10:11 2024 -0700 refactor: test utils to simplify assertThemedProps commit e777ea3 Author: Ali Stump <astump@esri.com> Date: Mon Apr 1 12:17:32 2024 -0700 docs: add jsdocs to common test utils commit c2244da Author: Ali Stump <astump@esri.com> Date: Mon Apr 1 12:03:21 2024 -0700 tests: test theme-ing for stateful tokens commit ec2ec64 Author: Ali Stump <astump@esri.com> Date: Wed Mar 27 12:26:56 2024 -0700 test: allow theme tests to penetrate subcomponent shadow dom commit 2e0e1d8 Author: Ali Stump <astump@esri.com> Date: Tue Mar 26 16:52:00 2024 -0700 chore: update common theme-ing tests commit e1d204f Author: Ali Stump <astump@esri.com> Date: Mon Mar 25 15:32:01 2024 -0700 chore(common): add non-color values for tokenList in themed commit 2a9472c Author: Ali Stump <astump@esri.com> Date: Mon Mar 25 15:27:59 2024 -0700 chore(common): add themed common test
these tokens are unused as the action-group in the shadow dom does not use popover or have it’s own border and all other elements in the action bar are slotted and so should have their own styles.
…components into astump/7180-fix-action-bar # Conflicts: # packages/calcite-components/src/tests/commonTests.ts # packages/calcite-components/src/tests/utils.ts
jcfranco
approved these changes
Apr 11, 2024
| @@ -62,7 +62,7 @@ const setTooltipReference = ({ | |||
| return referenceElement; | |||
| }; | |||
|
|
|||
| export const ExpandToggle: FunctionalComponent<ExpandToggleProps> = ({ | |||
| export const ExpandToggle: FunctionalComponent<ExpandToggleProps & any> = ({ | |||
There was a problem hiding this comment.
ExpandToggleProps should extend JSXBase.HTMLAttributes instead of using any here (see example).
…components into astump/7180-fix-action-bar
…components into astump/7180-fix-action-bar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Should be merged after #9027
Action Bar
--calcite-action-bar-expanded-max-width: When
layoutis"vertical", specifies the expanded max width of the component.--calcite-action-bar-trigger-background-color-active: Specifies the background color of the nested trigger when active in the component.
--calcite-action-bar-trigger-background-color-focus: Specifies the background color of the nested trigger when focused in the component.
--calcite-action-bar-trigger-background-color-hover: Specifies the background color of the nested trigger when hovered in the component.
--calcite-action-bar-trigger-background-color: Specifies the background color of the nested trigger in the component.
--calcite-action-bar-trigger-icon-color-active: Specifies the icon color color of the nested trigger when active in the component
--calcite-action-bar-trigger-icon-color-focus: Specifies the icon color of the nested trigger when focused in the component.
--calcite-action-bar-trigger-icon-color-hover: Specifies the icon color of the nested trigger when hovered in the component.
--calcite-action-bar-trigger-icon-color: Specifies the icon color of the nested trigger in the component.
--calcite-action-bar-trigger-loader-color: Specifies the loader color of the nested trigger in the component component.
--calcite-action-bar-trigger-shadow-active: Specifies the shadow of the nested trigger when active in the component.
--calcite-action-bar-trigger-shadow-focus: Specifies the shadow of the nested trigger when focused in the component.
--calcite-action-bar-trigger-shadow-hover: Specifies the shadow of the nested trigger when hovered in the component.
--calcite-action-bar-trigger-shadow: Specifies the shadow of the nested trigger in the component.
--calcite-action-bar-trigger-text-color-active: Specifies the text color of the nested trigger when active in the component.
--calcite-action-bar-trigger-text-color-focus: Specifies the text color of the nested trigger when focused in the component.
--calcite-action-bar-trigger-text-color-hover: Specifies the text color of the nested trigger when hovered in the component.
--calcite-action-bar-trigger-text-color: Specifies the text color of the nested trigger in the component.