-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(common): add prop theme utility for E2E #9027
Merged
alisonailea
merged 11 commits into
epic/7180-component-tokens
from
astump/7180-add-e2e-tests
Apr 8, 2024
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
2a9472c
chore(common): add themed common test
alisonailea e1d204f
chore(common): add non-color values for tokenList in themed
alisonailea 2e0e1d8
chore: update common theme-ing tests
alisonailea ec2ec64
test: allow theme tests to penetrate subcomponent shadow dom
alisonailea c2244da
tests: test theme-ing for stateful tokens
alisonailea e777ea3
docs: add jsdocs to common test utils
alisonailea 6b78dfb
refactor: test utils to simplify assertThemedProps
alisonailea 377dc68
refactor(common): simplify theme tests to be more readable
alisonailea d8dbc9a
docs(common): add required “as const” to example
alisonailea 3e3e2fe
test(common): move assignTestTokenThemeValues to commonTests
alisonailea 0318e55
chore(common): don’t export helper functions for common tests
alisonailea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use
Array.isArray
instead of adding a custom function for this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no. The custom type guard is required. See microsoft/TypeScript#19892
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you seeing incorrect types or a particular TS error? The issue you referenced is related to
ReadOnlyArray
type, which we are not using.Types seem fine in both code paths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That doesn't work for me. It says it doesn't know if it's a string or an array.