build(components.d.ts): update types for release #9008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geospatialem
approved these changes
Mar 27, 2024
This was referenced Mar 27, 2024
benelan
added a commit
that referenced
this pull request
Mar 30, 2024
**Related Issue:** #9008 ## Summary Commit changes to `components.d.ts` after building for release to prevent lerna/npm publishing errors due to an unclean working tree. The commit will be discarded once the workflow run's container is destroyed. ### Background The `components.d.ts` file is tracked as a temporary workaround for ionic-team/stencil#3239 To keep the types updated, `components.d.ts` is added to the index in a pre-commit hook. https://github.com/Esri/calcite-design-system/blob/2bb1ee24bb317c95e2bef8165c75583fe98ad714/.husky/pre-commit#L7-L13 However, the file can still be outdated if people make changes and don't rebuild before creating another commit. This is mostly an issue with small doc updates, like the PR linked above. If that happens, the release will fail due to an unclean working tree.
benelan
added a commit
that referenced
this pull request
Mar 30, 2024
**Related Issue:** #9008 ## Summary Add troubleshooting steps to the release documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The release failed due to the
components.d.tsfile being outdated, with the following error:I will add an actual fix to the CI in a subsequent PR.