fix(table): fix style regression #8991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move theming-related tests to stories * drop unnecessary tests
jcfranco
commented
Mar 25, 2024
alisonailea
approved these changes
Mar 25, 2024
alisonailea
requested changes
Mar 25, 2024
There was a problem hiding this comment.
I'd like to revert the removal of theme tests from e2e. The added VRT tests do not fully cover the token values and it is very easy for a human to miss subtle color changes (especially random colors like we are using) resulting in several accepted faulty VRT tests due to human error. Unit tests are better in this case. Since they represent a data application change not an alteration to our underlaying style assignments.
packages/calcite-components/src/components/action/action.stories.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/action-menu/action-menu.stories.ts
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/modal/modal.stories.ts
Outdated
Show resolved
Hide resolved
| expect(scrimStyles.trim()).toEqual("rgba(0, 0, 0, 0.85)"); | ||
| }); | ||
|
|
||
| it("when modal css override set, scrim should adhere to requested color", async () => { |
There was a problem hiding this comment.
There is no replacement for these tests ATM
jcfranco
commented
Mar 26, 2024
packages/calcite-components/src/components/modal/modal.stories.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
✨🏓🔨✨