Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): prevent spacebar from opening the menu when focused on chip's close button #8990

Merged
merged 2 commits into from
Mar 25, 2024
Merged

fix(combobox): prevent spacebar from opening the menu when focused on chip's close button #8990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93f8817
fix(combobox): prevent spacebar from opening the menu when focused on…
Elijbet Mar 22, 2024
3bd40df
cleanup✨🧼✨
Elijbet Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/calcite-components/src/components/combobox/combobox.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1959,7 +1959,7 @@ describe("calcite-combobox", () => {

const wrapper = await page.find("calcite-combobox >>> .wrapper");
const close = await wrapper.find("calcite-chip >>> .close");
await close.click();
await close.press(" ");
await page.waitForChanges();

const remainingChips = await page.findAll("calcite-combobox >>> calcite-chip");
Expand Down
6 changes: 1 addition & 5 deletions packages/calcite-components/src/components/combobox/combobox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -681,17 +681,13 @@ export class Combobox
}
break;
case " ":
if (!this.textInput.value) {
if (!this.textInput.value && !event.defaultPrevented) {
if (!this.open) {
this.open = true;
this.shiftActiveItemIndex(1);
}
event.preventDefault();
}

if (event.composedPath().find((el: HTMLElement) => el.tagName === "CALCITE-CHIP")) {
event.preventDefault();
}
break;
case "Home":
if (!this.open) {
Expand Down
Loading