Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add component tokens #8951

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Mar 18, 2024

Related Issue: #7180

Summary

Adds the following component tokens (CSS props):

  • --calcite-modal-accent-color
  • --calcite-modal-background-color
  • --calcite-modal-border-color
  • --calcite-modal-close-button-background-color-hover
  • --calcite-modal-close-button-background-color
  • --calcite-modal-close-button-icon-color
  • --calcite-modal-content-background-color
  • --calcite-modal-content-space
  • --calcite-modal-corner-radius
  • --calcite-modal-scrim-background-color
  • --calcite-modal-shadow
  • --calcite-modal-text-color

Deprecates the following:

  • --calcite-modal-content-background
  • --calcite-modal-content-padding
  • --calcite-modal-scrim-background

This additionally updates naming on internal props.

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 18, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 18, 2024
@jcfranco jcfranco marked this pull request as ready for review March 18, 2024 19:41
@jcfranco jcfranco requested a review from a team as a code owner March 18, 2024 19:41
@jcfranco jcfranco requested a review from macandcheese March 18, 2024 21:47
Copy link
Contributor

@macandcheese macandcheese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏅

@jcfranco jcfranco merged commit ceb60da into epic/7180-component-tokens Mar 19, 2024
4 checks passed
@jcfranco jcfranco deleted the jcfranco/7180-add-component-tokens-to-modal branch March 19, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants