Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(navigation-user): allows theming with tokens #8918

Merged
merged 2 commits into from
Mar 9, 2024
Merged

fix(navigation-user): allows theming with tokens #8918

merged 2 commits into from
Mar 9, 2024

Conversation

anveshmekala
Copy link
Contributor

@anveshmekala anveshmekala commented Mar 8, 2024 •
edited
Loading

Related Issue: #7180

Summary

Allows theming with tokens and removes --calcite-navigation-user-text-color token from navigation-user.

@anveshmekala anveshmekala added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 8, 2024
@anveshmekala anveshmekala added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 8, 2024
@anveshmekala anveshmekala marked this pull request as ready for review March 8, 2024 22:02
@anveshmekala anveshmekala requested a review from a team as a code owner March 8, 2024 22:02
alisonailea
alisonailea reviewed Mar 9, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick question about the text-color. Is the component is expecting for a text color to be set or can it inherit the value from it's parent?

packages/calcite-components/src/components/navigation-user/navigation-user.scss Show resolved Hide resolved
@anveshmekala
Copy link
Contributor Author

quick question about the text-color. Is the component is expecting for a text color to be set or can it inherit the value from it's parent?

I don't think text-color needs to be set for this component since there are no elements that needs the color property. The component has avatar ,username & full name which can be themed using the specific tokens and slotting is not expected.

@anveshmekala anveshmekala merged commit 19998e6 into epic/7180-component-tokens Mar 9, 2024
8 checks passed
@anveshmekala anveshmekala deleted the anveshmekala/7180-navigation-user-refactor branch March 9, 2024 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

Assignees
No one assigned
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anveshmekala @alisonailea