-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(navigation-logo): adds component tokens #8894
feat(navigation-logo): adds component tokens #8894
Conversation
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per Adam's comment. I don't think we need stateful tokens here. I've shown three ways to get to the tokens we need here. I'd vote 1. or 2. but it's up to you.
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/navigation-logo/navigation-logo.scss
Outdated
Show resolved
Hide resolved
This part i am bit confused. Initially had them and later removed them and added back. The refactor doc says tokens should be added for appropriate states. I can see the reasoning for adding them since hover and active are appropriate states for navigation-logo component. On the other hand, user can simply set the state on component selector and change the token variable if required. Are we adding state tokens for components which are inaccessible to the user (inside shadowDOM) or components which can used as sub-components for other components? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Looks great! Thanks
Related Issue: #7180
Summary
Adds the following tokens in
calcite-navigation-logo
component