Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tab-nav): add component tokens #8853

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 29, 2024

Related Issue: #7180

Summary

Adds the following component tokens (CSS props):

  • --calcite-tab-nav-indicator-color
  • --calcite-tab-nav-button-background-color
  • --calcite-tab-nav-button-background-color-active
  • --calcite-tab-nav-button-background-color-focus
  • --calcite-tab-nav-button-background-color-hover
  • --calcite-tab-nav-button-border-color
  • --calcite-tab-nav-button-border-color-active
  • --calcite-tab-nav-button-border-color-focus
  • --calcite-tab-nav-button-border-color-hover
  • --calcite-tab-nav-button-icon-color
  • --calcite-tab-nav-button-icon-color-active
  • --calcite-tab-nav-button-icon-color-focus
  • --calcite-tab-nav-button-icon-color-hover

Note: scroll button prop assignment is depends on button refactor.

@jcfranco jcfranco requested a review from a team as a code owner February 29, 2024 07:44
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good

@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Mar 1, 2024
@jcfranco jcfranco requested a review from alisonailea March 1, 2024 00:39
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 1, 2024
@jcfranco jcfranco merged commit 602f9e8 into epic/7180-component-tokens Mar 1, 2024
9 checks passed
@jcfranco jcfranco deleted the jcfranco/7180-add-component-tokens-to-tab-nav branch March 1, 2024 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants