feat(action menu): add component tokens #8837
Conversation
There was a problem hiding this comment.
This looks good besides the missing popover tokens.
Because the PR and commit reference just a feature for action-menu, i wouldn't expect tokens added to block, menu-item, panel, action-group. I think this is fine its just a little odd to be updating other components. I would expect the updates to the other components to handle the vars for action-menu once its merged.
As stated in my suggested workflow proposal document. It should be up to the person with the most knowledge of those component tokens to update them in dependent components. This workflow means no component is blocked by any other. |
Related Issue: #7180
Summary
Adds Action-Menu component tokens and sub-component tokens to Calcite Components
Action Group
--calcite-action-group-action-menu-border-color: The border color of the sub-component.
--calcite-action-group-action-menu-text-color: The text color of the sub-component.
Action Menu
--calcite-action-menu-border-color: The border color of the component.
--calcite-action-menu-text-color: The text color of the component.
Block
--calcite-block-action-menu-border-color: The border color of the sub-component.
--calcite-block-action-menu-text-color: The text color of the sub-component.
Menu Item
--calcite-menu-item-action-menu-border-color: The border color of the sub-component.
--calcite-menu-item-action-menu-text-color: The text color of the sub-component.
Panel
--calcite-panel-action-menu-border-color: The border color of the sub-component.
--calcite-panel-action-menu-text-color: The text color of the sub-component.