Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(radio-button, radio-button-group): add component tokens #8831

Merged
merged 14 commits into from
Mar 5, 2024
Merged

feat(radio-button, radio-button-group): add component tokens #8831

merged 14 commits into from
Mar 5, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Feb 26, 2024 •
edited
Loading

Related Issue: #7180

Summary

Radio Button

 * @prop --calcite-radio-button-background-color: Specifies the background color of the component.
 * @prop --calcite-radio-button-border-radius: Specifies the border radius of the component.
 * @prop --calcite-radio-focus: Specifies the focus of the component.
 * @prop --calcite-radio-button-shadow: Specifies the shadow of the component.
 * @prop --calcite-radio-button-size: Specifies the size of the component.

@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 26, 2024
@driskull driskull removed the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 26, 2024
@driskull driskull marked this pull request as ready for review February 26, 2024 22:27
@driskull driskull requested a review from a team as a code owner February 26, 2024 22:27
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 26, 2024
@driskull driskull mentioned this pull request Feb 26, 2024
Open
alisonailea
alisonailea requested changes Feb 27, 2024
View reviewed changes
packages/calcite-components/src/components/radio-button-group/radio-button-group.scss Outdated
}

:host([scale="s"]) calcite-input-message {
--calcite-input-message-spacing-value: calc(var(--calcite-spacing-xxs) * -1);
--calcite-input-message-spacing-value: calc(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to an -internal- var

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alisonailea --calcite-radio-button-group-input-message-space should be internal? Then a user wouldn't be able to set the spacing for the input-message component.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why we'd want folks to adjust the distance between the input message and the control. Are there examples where we see this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only added this because its a var on the input-message.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Yeah maybe we can deprecate it there if it isn't. A standalone instance of the component can just be spaced with css on the element.

@driskull
ordering
aa6d179
@driskull
Merge branch 'epic/7180-component-tokens' into dris0000/7180-radio
65c7d5f 
# Conflicts:
#	packages/calcite-components/src/assets/styles/includes.scss
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 5, 2024
@driskull driskull merged commit e36324b into epic/7180-component-tokens Mar 5, 2024
8 checks passed
@driskull driskull deleted the dris0000/7180-radio branch March 5, 2024 18:07
@eriklharper
Copy link
Contributor

Once the main tokens branch is merged to main we should be able to mark this issue resolved: #8658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

@macandcheese macandcheese Awaiting requested review from macandcheese

Assignees
No one assigned
Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@driskull @eriklharper @alisonailea @macandcheese