-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(date-picker): add component tokens #8822
Merged
anveshmekala
merged 14 commits into
epic/7180-component-tokens
from
anveshmekala/71890-date-picker-month-add-component-tokens
Mar 5, 2024
Merged
feat(date-picker): add component tokens #8822
anveshmekala
merged 14 commits into
epic/7180-component-tokens
from
anveshmekala/71890-date-picker-month-add-component-tokens
Mar 5, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anveshmekala
changed the title
feat(date-picker-month): add component tokens
feat(date-picker,date-picker-month): add component tokens
Feb 23, 2024
anveshmekala
added
the
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
label
Feb 24, 2024
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Feb 26, 2024
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Feb 26, 2024
anveshmekala
changed the title
feat(date-picker,date-picker-month): add component tokens
feat(date-picker,date-picker-month,date-picker-day): add component tokens
Feb 26, 2024
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Feb 26, 2024
anveshmekala
changed the title
feat(date-picker,date-picker-month,date-picker-day): add component tokens
feat(date-picker): add component tokens
Feb 26, 2024
alisonailea
requested changes
Feb 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting there. Just a few things.
- Remove "internal" from all component token names that are
-
- Background color
-
- color
-
- border color
-
- shadow (box-shadow)
-
- icon color (fill/stroke)
-
- corner radius (border-radius)
- Make sure none of the above tokens are assigned values like on date-picker-day.scss:161
- add some docs to date-picker-day.scss.
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Outdated
Show resolved
Hide resolved
packages/calcite-components/src/components/date-picker-day/date-picker-day.scss
Show resolved
Hide resolved
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Mar 1, 2024
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Mar 1, 2024
…e-picker-month-add-component-tokens
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Mar 1, 2024
alisonailea
approved these changes
Mar 5, 2024
…e-picker-month-add-component-tokens
anveshmekala
added
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
and removed
pr ready for visual snapshots
Adding this label will run visual snapshot testing.
labels
Mar 5, 2024
anveshmekala
deleted the
anveshmekala/71890-date-picker-month-add-component-tokens
branch
March 5, 2024 16:47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #
Summary
Adds following tokens for
calcite-date-picker
component.