feat(label): add component tokens #8796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macandcheese
approved these changes
Feb 21, 2024
There was a problem hiding this comment.
Looks good pending alignment with resolution of #8790 nomenclature discussion for margin-bottom / space-block-end
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
alisonailea
requested changes
Mar 5, 2024
alisonailea
approved these changes
Mar 5, 2024
|
Note: if a different base font size was previously used, there will be a difference in spacing between elements in labels. This is because the gap is now using px and no longer rem-based. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #7180
Summary
Adds the following component tokens (CSS props):
--calcite-label-space-y-end--calcite-label-text-colorDeprecates the following:
--calcite-label-margin-bottom