Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(block-section): add component tokens #8795

Merged
merged 9 commits into from
Mar 5, 2024
Merged

feat(block-section): add component tokens #8795

merged 9 commits into from
Mar 5, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Feb 21, 2024 •
edited
Loading

Related Issue: #7180

Summary

Adds the following component tokens:

  • --calcite-block-section-background-color
  • --calcite-block-section-border-color
  • --calcite-block-section-heading-text-color
  • --calcite-block-section-heading-text-color-hover

Note: added internal icon color token for upcoming icon prop.

@jcfranco jcfranco requested a review from a team as a code owner February 21, 2024 03:45
@jcfranco jcfranco added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 21, 2024
@jcfranco jcfranco mentioned this pull request Feb 21, 2024
Open
@macandcheese
Copy link
Contributor

Note: component tokens for status icon color are intentionally skipped since status and icon will be #8110.

We might want to just add the icon css property now as that issue actually adds an icon property.

@jcfranco
Copy link
Member Author

@macandcheese Oh, great catch. I totally misread that issue. 😅 I'll also update block since I referenced the same issue, and #4932 suggests the same changes.

@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Feb 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 29, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 2, 2024
@jcfranco jcfranco added skip visual snapshots Pull requests that do not need visual regression testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Mar 2, 2024
@jcfranco jcfranco merged commit 13c4432 into epic/7180-component-tokens Mar 5, 2024
7 checks passed
@jcfranco jcfranco deleted the jcfranco/7180-add-component-tokens-to-block-section branch March 5, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonailea alisonailea alisonailea approved these changes

Assignees
No one assigned
Labels
skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcfranco @macandcheese @alisonailea