Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop Firefox-specific logic for consistent disabled behavior #8732

Merged

Conversation

jcfranco
Copy link
Member

Related Issue: #8729

Summary

Removes workaround needed for Firefox versions prior to 116, which is now covered by FF ESR (v115+).

Note: test environment is Chromium-based, so no tests were updated.

@jcfranco jcfranco requested a review from a team as a code owner February 13, 2024 03:16
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Feb 13, 2024
@github-actions github-actions bot added the bug Bug reports for broken functionality. Issues should include a reproduction of the bug. label Feb 13, 2024
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👏

@jcfranco jcfranco added p - medium Issue is non core or affecting less that 60% of people using the library and removed p - medium Issue is non core or affecting less that 60% of people using the library labels Feb 13, 2024
@jcfranco
Copy link
Member Author

jcfranco commented Feb 13, 2024

Per #8729 (comment), putting this on hold until the next FF ESR update (September 3rd, 2024).

@jcfranco jcfranco marked this pull request as draft February 15, 2024 00:00
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 22, 2024
@benelan benelan changed the base branch from main to dev June 10, 2024 09:16
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Jun 12, 2024
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Jun 20, 2024
@jcfranco jcfranco changed the title fix: ensure disabled components in Firefox behave consistently refactor: drop Firefox-specific logic for consistent disabled behavior Aug 28, 2024
@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Aug 28, 2024
@jcfranco jcfranco removed the Stale Issues or pull requests that have not had recent activity. label Aug 28, 2024
@jcfranco jcfranco marked this pull request as ready for review August 28, 2024 22:53
@jcfranco jcfranco requested a review from benelan August 28, 2024 22:53
@jcfranco jcfranco requested a review from driskull August 28, 2024 22:57
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! Lots of code 💥 👋

@jcfranco jcfranco merged commit 1cb3d90 into dev Aug 29, 2024
11 checks passed
@jcfranco jcfranco deleted the jcfranco/8729-drop-unnecessary-firefox-disabled-workaround branch August 29, 2024 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug reports for broken functionality. Issues should include a reproduction of the bug. refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants