Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add angular template link to issue templates #8680

Merged
merged 6 commits into from
Feb 7, 2024

Conversation

DitwanP
Copy link
Contributor

@DitwanP DitwanP commented Jan 31, 2024

Related Issue: #8567

Summary

Add a link to the bug and a11y issue templates for this codesandbox that I created as a calcite components angular template.

@github-actions github-actions bot added the chore Issues with changes that don't modify src or test files. label Jan 31, 2024
@DitwanP DitwanP added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 31, 2024
@DitwanP DitwanP marked this pull request as ready for review January 31, 2024 20:12
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome updates! 🧰

WRT the Codesandbox Angular sample, WDYT about the following considerations?:

  1. Adding a NgIf directive to conditionally display content similar to our Angular example in calcite-components-examples?
  2. Adding a template variable, also similar to our Angular example in calcite-components-examples?

Both are used fairly regular in Angular, so could be good considerations for the template to get folks started.

@DitwanP
Copy link
Contributor Author

DitwanP commented Feb 2, 2024

Awesome updates! 🧰

WRT the Codesandbox Angular sample, WDYT about the following considerations?:

  1. Adding a NgIf directive to conditionally display content similar to our Angular example in calcite-components-examples?
  2. Adding a template variable, also similar to our Angular example in calcite-components-examples?

Both are used fairly regular in Angular, so could be good considerations for the template to get folks started.

Yeah that makes sense, I'll get that in there.

@DitwanP DitwanP requested a review from geospatialem February 2, 2024 22:33
Copy link
Member

@geospatialem geospatialem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌟🚀🌟

Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding this! A couple minor notes:

  • You can remove the @esri/calcite-components dependency since it is included with @esri/calcite-components-angular.

  • You should be able to remove all of these jasmine and karma deps since there aren't any tests in the sample. Doing so might make the app load faster.

    "devDependencies": {
        "@types/jasmine": "3.6.3",
        "@types/jasminewd2": "2.0.8",
        "jasmine-core": "3.6.0",
        "jasmine-spec-reporter": "6.0.0",
        "karma": "6.1.1",
        "karma-chrome-launcher": "3.1.0",
        "karma-coverage-istanbul-reporter": "3.0.3",
        "karma-jasmine": "4.0.1",
        "karma-jasmine-html-reporter": "1.5.4"
      }
  • We may want to use the jsdelivr or unpkg CDN for the assets like the React sample does so we don't need to update the hardcoded version after every release.

    defineCustomElements(window, {
      resourcesUrl: "https://cdn.jsdelivr.net/npm/@esri/calcite-components@latest/dist/calcite/assets",
    });

@DitwanP
Copy link
Contributor Author

DitwanP commented Feb 6, 2024

@benelan Great suggestions! I'll make those adjustments, thank you.

@DitwanP DitwanP added the low risk Issues with low risk for consideration in low risk milestones label Feb 7, 2024
@DitwanP DitwanP merged commit b4ef364 into main Feb 7, 2024
13 of 14 checks passed
@DitwanP DitwanP deleted the dit13711/add-angular-template-link-to-issue-templates branch February 7, 2024 20:17
benelan added a commit that referenced this pull request Feb 7, 2024
* benelan/bump-deps:
  chore: cleanup
  chore: cleanup
  chore: release next
  fix: don't override existing validationMessage when displaying after form submission (#8690)
  build(deps): downgrade broken icons version
  chore: cleanup
  chore: add angular template link to issue templates (#8680)
Elijbet pushed a commit that referenced this pull request Feb 15, 2024
**Related Issue:** #8567

## Summary
Add a link to the bug and a11y issue templates for this
[codesandbox](https://codesandbox.io/p/sandbox/little-fire-2hx4qh?file=%2Fsrc%2Fapp%2Fapp.component.html%3A16%2C51)
that I created as a calcite components angular template.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issues with changes that don't modify src or test files. low risk Issues with low risk for consideration in low risk milestones skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants