-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add angular template link to issue templates #8680
chore: add angular template link to issue templates #8680
Conversation
…into dit13711/add-link-to-angular-template-to-issue-templates
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome updates! 🧰
WRT the Codesandbox Angular sample, WDYT about the following considerations?:
- Adding a NgIf directive to conditionally display content similar to our Angular example in
calcite-components-examples
? - Adding a template variable, also similar to our Angular example in
calcite-components-examples
?
Both are used fairly regular in Angular, so could be good considerations for the template to get folks started.
Yeah that makes sense, I'll get that in there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌟🚀🌟
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for adding this! A couple minor notes:
-
You can remove the
@esri/calcite-components
dependency since it is included with@esri/calcite-components-angular
. -
You should be able to remove all of these
jasmine
andkarma
deps since there aren't any tests in the sample. Doing so might make the app load faster."devDependencies": { "@types/jasmine": "3.6.3", "@types/jasminewd2": "2.0.8", "jasmine-core": "3.6.0", "jasmine-spec-reporter": "6.0.0", "karma": "6.1.1", "karma-chrome-launcher": "3.1.0", "karma-coverage-istanbul-reporter": "3.0.3", "karma-jasmine": "4.0.1", "karma-jasmine-html-reporter": "1.5.4" }
-
We may want to use the jsdelivr or unpkg CDN for the assets like the React sample does so we don't need to update the hardcoded version after every release.
defineCustomElements(window, { resourcesUrl: "https://cdn.jsdelivr.net/npm/@esri/calcite-components@latest/dist/calcite/assets", });
@benelan Great suggestions! I'll make those adjustments, thank you. |
**Related Issue:** #8567 ## Summary Add a link to the bug and a11y issue templates for this [codesandbox](https://codesandbox.io/p/sandbox/little-fire-2hx4qh?file=%2Fsrc%2Fapp%2Fapp.component.html%3A16%2C51) that I created as a calcite components angular template.
Related Issue: #8567
Summary
Add a link to the bug and a11y issue templates for this codesandbox that I created as a calcite components angular template.