Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(progress): add component tokens #8661

Merged
merged 6 commits into from
Feb 21, 2024
Merged

feat(progress): add component tokens #8661

merged 6 commits into from
Feb 21, 2024

Conversation

Elijbet
Copy link
Contributor

@Elijbet Elijbet commented Jan 28, 2024 •
edited
Loading

Related Issue: #7180

Summary

Adds the following component tokens : 🥇

--calcite-progress-background-color: defines the background color of the component.
--calcite-progress-bar-fill-color: defines the background color of the progress bar.
--calcite-progress-text-color: defines the text color of the component.

@Elijbet Elijbet changed the title Elijbet/7180 add component tokens for progress feat(progress): add component tokens Jan 28, 2024
@Elijbet Elijbet changed the base branch from main to epic/7180-component-tokens January 28, 2024 23:56
@Elijbet Elijbet marked this pull request as ready for review January 28, 2024 23:57
@Elijbet Elijbet requested a review from a team as a code owner January 28, 2024 23:57
alisonailea
alisonailea requested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good! Component tokens should be set at :host in most cases.

packages/calcite-components/src/components/progress/progress.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/progress/progress.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/progress/progress.scss Outdated Show resolved Hide resolved
packages/calcite-components/src/components/progress/progress.scss Outdated Show resolved Hide resolved
@Elijbet Elijbet mentioned this pull request Jan 29, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2024

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Feb 6, 2024
@alisonailea alisonailea added design-tokens Issues requiring design tokens. and removed Stale Issues or pull requests that have not had recent activity. labels Feb 14, 2024
@Elijbet Elijbet force-pushed the elijbet/7180-add-component-tokens-for-progress branch from 1249127 to 6d54811 Compare February 17, 2024 23:40
alisonailea
alisonailea requested changes Feb 21, 2024
View reviewed changes
Copy link
Contributor

@alisonailea alisonailea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor thing on text-color. Looks good!

packages/calcite-components/src/components/progress/progress.scss Outdated Show resolved Hide resolved
@Elijbet Elijbet added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Feb 21, 2024
@Elijbet Elijbet merged commit a9161fb into epic/7180-component-tokens Feb 21, 2024
8 of 9 checks passed
@Elijbet Elijbet deleted the elijbet/7180-add-component-tokens-for-progress branch February 21, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macandcheese macandcheese macandcheese left review comments

@alisonailea alisonailea alisonailea approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco

@benelan benelan Awaiting requested review from benelan

@driskull driskull Awaiting requested review from driskull

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@Elijbet Elijbet

Labels
design-tokens Issues requiring design tokens. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elijbet @alisonailea @macandcheese