Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove @ts-ignore needed for Stencil missing in JSX types #8551

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Jan 4, 2024

Related Issue: N/A

Summary

Stencil 4.8.0 added inert to the JSX types, so this is no longer needed.

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Jan 4, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Jan 4, 2024
@jcfranco jcfranco marked this pull request as ready for review January 4, 2024 18:36
@jcfranco jcfranco requested a review from a team as a code owner January 4, 2024 18:36
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit ed1fe2b into main Jan 4, 2024
12 checks passed
@jcfranco jcfranco deleted the jcfranco/remove-no-longer-needed-ts-ignore branch January 4, 2024 23:19
@github-actions github-actions bot added this to the 2024-01-17 - Jan Main Release milestone Jan 4, 2024
benelan added a commit that referenced this pull request Jan 5, 2024
…-not-internal

* origin/main:
  refactor: remove @ts-ignore needed for Stencil missing  in JSX types (#8551)
  refactor(combobox): remove unused interface (#8552)
  fix(input-date-picker): ensure range icon toggles open corresponding date-picker (#8554)
  fix(button): avoid needlessly overwriting title (#8491)
benelan added a commit that referenced this pull request Jan 5, 2024
…idation-ui

* origin/main:
  refactor: remove @ts-ignore needed for Stencil missing  in JSX types (#8551)
  refactor(combobox): remove unused interface (#8552)
  fix(input-date-picker): ensure range icon toggles open corresponding date-picker (#8554)
  fix(button): avoid needlessly overwriting title (#8491)
benelan added a commit that referenced this pull request Jan 5, 2024
…mber-infinity

* origin/main:
  refactor: remove @ts-ignore needed for Stencil missing  in JSX types (#8551)
  refactor(combobox): remove unused interface (#8552)
  fix(input-date-picker): ensure range icon toggles open corresponding date-picker (#8554)
  fix(button): avoid needlessly overwriting title (#8491)
  docs(d, f, g, and h-named components): update api description refs (#8540)
  docs(b and c components): consistent api description refs (#8536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants