Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: consistent api description refs m thru s-comps #8545

Merged
merged 2 commits into from
Jan 5, 2024
Merged

docs: consistent api description refs m thru s-comps #8545

merged 2 commits into from
Jan 5, 2024

Conversation

geospatialem
Copy link
Member

Related Issue: #7071

Summary

Updates doc consistency across m through s-named components defined in the above issue for props, events, methods, and css vars, including:

  • meter
    • Also includes some inconsistencies in the prop names
  • modal
  • navigation-logo
  • navigation-user
  • navigation
  • notice
  • pick-list
  • popover
  • select
  • sheet
  • shell-panel
  • slider
  • split-button

@geospatialem geospatialem added docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing. labels Jan 3, 2024
@geospatialem geospatialem requested a review from a team as a code owner January 3, 2024 00:59
benelan
benelan approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@benelan benelan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@geospatialem geospatialem merged commit 0f1aec2 into main Jan 5, 2024
11 checks passed
@geospatialem geospatialem deleted the geospatialem/7071-docs-api-desc-prs-components branch January 5, 2024 21:20
@github-actions github-actions bot added this to the 2024-01-17 - Jan Main Release milestone Jan 5, 2024
benelan added a commit that referenced this pull request Jan 6, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/8000-form-val…
eb96ae6 
…idation-ui

* origin/main:
  refactor(slider): simplify rendering (#8475)
  docs: consistent api description refs m thru s-comps (#8545)
  chore: release next
  fix(list, list-item, list-item-group): honor hidden attribute on list-item and list-item-group (#8541)
benelan added a commit that referenced this pull request Jan 9, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/radio-validat…
fb698ef 
…ion-message

* origin/main:
  fix(action): update component tokens to support transparent (#8532)
  build: update browserslist db (#8565)
  fix(input, input-number, input-text): restore focus on input after browser validation error is displayed and user continues typing (#8563)
  docs(various components): consistent api description refs (#8550)
  refactor(slider): simplify rendering (#8475)
  docs: consistent api description refs m thru s-comps (#8545)
  chore: release next
  fix(list, list-item, list-item-group): honor hidden attribute on list-item and list-item-group (#8541)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

Assignees

@geospatialem geospatialem

Labels
docs Issues relating to documentation updates only. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

Successfully merging this pull request may close these issues.
2 participants
@geospatialem @benelan